Field jaeger.version is empty when using quarkus-jaeger

[ctron]

Describe the bug
(Describe the problem clearly and concisely.)

The field jaeger.version is empty.

Expected behavior

The field should contain the version of the Jaeger tracing library.

Actual behavior

The field value is empty.

To Reproduce
Steps to reproduce the behavior:

1. Using qauarkus-jaeger

Screenshots

Environment (please complete the following information):

$ uname -a
Linux brocken 5.6.19-300.fc32.x86_64 #1 SMP Wed Jun 17 16:10:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
$ java -version
openjdk version "11.0.7" 2020-04-14
OpenJDK Runtime Environment 18.9 (build 11.0.7+10)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.7+10, mixed mode, sharing)

• GraalVM version (if different from Java): 19.3.1

• Quarkus version or git rev: 1.5.2.Final

• Build tool (ie. output of mvnw --version or gradlew --version):

  Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
  Maven home: /home/jreimann/tools/maven/apache-maven-current
  Java version: 11.0.7, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-11-openjdk-11.0.7.10-1.fc32.x86_64
  Default locale: en_US, platform encoding: UTF-8
  OS name: "linux", version: "5.6.19-300.fc32.x86_64", arch: "amd64", family: "unix"
  

Additional context
(Add any other context about the problem here.)

[geoand]

cc @pavolloffay

[pavolloffay]

This should be set to the version of the Jaeger client library.

[geoand]

Shouldn't that be done automatically?

[pavolloffay]

it should, there is bug in jaeger client or quarkus.

[geoand]

Do you plan to look into it @pavolloffay ?

[ctron]

I think this is the root cause:

quarkus/extensions/jaeger/runtime/src/main/java/io/quarkus/jaeger/runtime/graal/Target_JaegerTracer.java

Lines 1 to 14 in 688ee16

	package io.quarkus.jaeger.runtime.graal;
	import com.oracle.svm.core.annotate.Substitute;
	import com.oracle.svm.core.annotate.TargetClass;
	@TargetClass(className = "io.jaegertracing.internal.JaegerTracer")
	public final class Target_JaegerTracer {
	@Substitute
	private static String loadVersion() {
	// TODO: Obtain Jaeger version
	return "";
	}
	}

[geoand]

@ctron oh... so this happens only in native mode?

[pavolloffay]

io.jaegertracing.client.Version.get() returns correct version for Jaeger 0.34.0 that is used in Quarkus.

The version is obtained from properties file https://github.com/jaegertracing/jaeger-client-java/blob/release-0.34/jaeger-core/src/main/java/io/jaegertracing/internal/JaegerTracer.java#L672. The prop file should be in the jar. Can this cause any problems in Quarkus?

[geoand]

Based on what @ctron posted, I am assuming the problem only occurs in native mode and that JVM mode works fine.

Let me come up with a real quick fix for this so we can get it in 1.6

[geoand]

I have a fix, let me just write a quick test so we can be sure this doesn't break in the future

[geoand]

#10405 should fix the issue

[ctron]

@ctron oh... so this happens only in native mode?

Indeed, sorry. I forgot to mention that.

[geoand]

No worries, I found out easily via testing.