QuarkusRestClientBuilder.newBuilder().build(TestRestService.class) is heavy/slow? Is proxy generated thread-safe?

[paul-luk]

I need to cater for dynamic URL from somewhere (e.g. user input / dynamic DB value)...

`
TestRestService client = QuarkusRestClientBuilder.newBuilder().baseUri(URI.create("https://xxxx")).build(TestRestService.class);

`
Creating a new TestRestService proxy should work but it seems be slow/heavy, right? Is the proxy thread-safe?

I am not able to get such information from quarkus page....

Can somebody share your way/experience?

Thanks

[geoand]

Creating a new TestRestService proxy should work but it seems be slow/heavy, right

It depends on what you mean :). What are you observing in practice?

Is the proxy thread-safe?

Do you mean the implementation of TestRestService that is created?

[paul-luk]

Creating a new TestRestService proxy should work but it seems be slow/heavy, right

It depends on what you mean :). What are you observing in practice?

I am migrating application from JavaEE to quarkus. Based on past experienced in JavaEE, creating 'proxy' on-the-fly repeatedly will cause some CPU overhead...

Is the proxy thread-safe?

Do you mean the implementation of TestRestService that is created?

Yes, I mean the proxy 'TestRestService' returned by the method build(...).

If the build(..) method is slow/CPU intensive and the 'TestRestService' proxy is not thread-safe, I need to adopt some object pooling mechanism (for performance/reduce CPU usage...etc).

[geoand]

Just to be clear, there is no proxy involved, we actually generate a class at build time that implements the interface. Here is an example:

// $VF: synthetic class
public class ExtensionsService$$QuarkusRestClientInterface extends RestClientBase implements Closeable, ExtensionsService {
   private WebTargetImpl baseTarget;
   private static final Method javaMethod1;
   final WebTargetImpl target1;
   static final Supplier javaMethodGenericParameters1;
   static final Supplier javaMethodParameterAnnotations1;
   private final HeaderFiller headerFiller1;
   private static final Method javaMethod2;
   final WebTargetImpl target2;
   static final Supplier javaMethodGenericParameters2;
   static final Supplier javaMethodParameterAnnotations2;
   private final HeaderFiller headerFiller2;
   private static final Method javaMethod3;
   final WebTargetImpl target3;
   static final Supplier javaMethodGenericParameters3;
   static final Supplier javaMethodParameterAnnotations3;
   private final HeaderFiller headerFiller3;

   public ExtensionsService$$QuarkusRestClientInterface(WebTarget var1, List var2) {
      super(var2);
      WebTargetImpl var3 = (WebTargetImpl)var1;
      var3 = var3.path("/extensions");
      this.baseTarget = var3;
      MicroProfileRestClientRequestFilter var4 = new MicroProfileRestClientRequestFilter(null);
      var3 = (WebTargetImpl)((Configurable)var3).register(var4);
      WebTarget var5 = (WebTarget)var3;
      String var6 = "";
      var5 = var5.path(var6);
      this.target1 = (WebTargetImpl)var5;
      NoOpHeaderFiller var7 = NoOpHeaderFiller.INSTANCE;
      this.headerFiller1 = (HeaderFiller)var7;
      WebTarget var8 = (WebTarget)var3;
      String var9 = "";
      var8 = var8.path(var9);
      this.target2 = (WebTargetImpl)var8;
      NoOpHeaderFiller var10 = NoOpHeaderFiller.INSTANCE;
      this.headerFiller2 = (HeaderFiller)var10;
      WebTarget var11 = (WebTarget)var3;
      String var12 = "";
      var11 = var11.path(var12);
      this.target3 = (WebTargetImpl)var11;
      NoOpHeaderFiller var13 = NoOpHeaderFiller.INSTANCE;
      this.headerFiller3 = (HeaderFiller)var13;
   }

   static {
      ClassLoader var0 = Thread.currentThread().getContextClassLoader();
      Class var1 = Class.forName("org.acme.rest.client.ExtensionsService", false, var0);
      Class[] var2 = new Class[]{String.class};
      javaMethod1 = var1.getMethod("getById", var2);
      Method var3 = javaMethod1;
      javaMethodGenericParameters1 = (Supplier)(new ParameterGenericTypesSupplier(var3));
      Method var4 = javaMethod1;
      javaMethodParameterAnnotations1 = (Supplier)(new ParameterAnnotationsSupplier(var4));
      Class[] var5 = new Class[]{String.class};
      javaMethod2 = var1.getMethod("getByIdAsUni", var5);
      Method var6 = javaMethod2;
      javaMethodGenericParameters2 = (Supplier)(new ParameterGenericTypesSupplier(var6));
      Method var7 = javaMethod2;
      javaMethodParameterAnnotations2 = (Supplier)(new ParameterAnnotationsSupplier(var7));
      Class[] var8 = new Class[]{String.class};
      javaMethod3 = var1.getMethod("getByIdAsync", var8);
      Method var9 = javaMethod3;
      javaMethodGenericParameters3 = (Supplier)(new ParameterGenericTypesSupplier(var9));
      Method var10 = javaMethod3;
      javaMethodParameterAnnotations3 = (Supplier)(new ParameterAnnotationsSupplier(var10));
   }

   public Set getById(String var1) {
      WebTarget var2 = (WebTarget)this.target1;
      Type var4 = ((Type[])javaMethodGenericParameters1.get())[0];
      Annotation[] var5 = ((Annotation[][])javaMethodParameterAnnotations1.get())[0];
      WebTarget var7;
      if (var1 != null) {
         Object[] var3 = ToObjectArray.value(var1);
         Object[] var6 = this.convertParamArray(var3, String.class, var4, var5);
         var7 = var2.queryParam("id", var6);
      } else {
         var7 = var2;
      }

      Builder var8 = var7.request();
      Method var9 = javaMethod1;
      var8 = var8.property("org.eclipse.microprofile.rest.client.invokedMethod", var9);
      HeaderFiller var10 = this.headerFiller1;
      var8 = var8.property("io.quarkus.rest.client.reactive.HeaderFiller", var10);
      Object[] var11 = new Object[]{var1};
      List var12 = Arrays.asList(var11);
      var8 = var8.property("io.quarkus.rest.client.invokedMethodParameters", var12);
      ClassLoader var13 = Thread.currentThread().getContextClassLoader();
      Type[] var14 = new Type[1];
      Class var15 = Class.forName("org.acme.rest.client.Extension", false, var13);
      var14[0] = var15;
      ParameterizedTypeImpl var16 = new ParameterizedTypeImpl(Set.class, var14);
      GenericType var17 = new GenericType((Type)var16);

      try {
         return (Set)var8.method("GET", var17);
      } catch (ProcessingException var20) {
         Throwable var19 = ((Throwable)var20).getCause();
         if (!(var19 instanceof RuntimeException)) {
            throw (Throwable)var20;
         } else {
            throw var19;
         }
      }
   }

   public Uni getByIdAsUni(String var1) {
      WebTarget var2 = (WebTarget)this.target2;
      Type var4 = ((Type[])javaMethodGenericParameters2.get())[0];
      Annotation[] var5 = ((Annotation[][])javaMethodParameterAnnotations2.get())[0];
      WebTarget var7;
      if (var1 != null) {
         Object[] var3 = ToObjectArray.value(var1);
         Object[] var6 = this.convertParamArray(var3, String.class, var4, var5);
         var7 = var2.queryParam("id", var6);
      } else {
         var7 = var2;
      }

      Builder var8 = var7.request();
      Method var9 = javaMethod2;
      var8 = var8.property("org.eclipse.microprofile.rest.client.invokedMethod", var9);
      HeaderFiller var10 = this.headerFiller2;
      var8 = var8.property("io.quarkus.rest.client.reactive.HeaderFiller", var10);
      Object[] var11 = new Object[]{var1};
      List var12 = Arrays.asList(var11);
      var8 = var8.property("io.quarkus.rest.client.invokedMethodParameters", var12);
      ClassLoader var13 = Thread.currentThread().getContextClassLoader();
      Type[] var14 = new Type[1];
      Class var15 = Class.forName("org.acme.rest.client.Extension", false, var13);
      var14[0] = var15;
      ParameterizedTypeImpl var16 = new ParameterizedTypeImpl(Set.class, var14);
      GenericType var19 = new GenericType((Type)var16);

      try {
         ClassLoader var17 = Thread.currentThread().getContextClassLoader();
         Class var18 = Class.forName("org.jboss.resteasy.reactive.client.impl.UniInvoker", false, var17);
         return ((UniInvoker)var8.rx(var18)).method("GET", var19);
      } catch (ProcessingException var22) {
         Throwable var21 = ((Throwable)var22).getCause();
         if (!(var21 instanceof RuntimeException)) {
            throw (Throwable)var22;
         } else {
            throw var21;
         }
      }
   }

   public CompletionStage getByIdAsync(String var1) {
      WebTarget var2 = (WebTarget)this.target3;
      Type var4 = ((Type[])javaMethodGenericParameters3.get())[0];
      Annotation[] var5 = ((Annotation[][])javaMethodParameterAnnotations3.get())[0];
      WebTarget var7;
      if (var1 != null) {
         Object[] var3 = ToObjectArray.value(var1);
         Object[] var6 = this.convertParamArray(var3, String.class, var4, var5);
         var7 = var2.queryParam("id", var6);
      } else {
         var7 = var2;
      }

      Builder var8 = var7.request();
      Method var9 = javaMethod3;
      var8 = var8.property("org.eclipse.microprofile.rest.client.invokedMethod", var9);
      HeaderFiller var10 = this.headerFiller3;
      var8 = var8.property("io.quarkus.rest.client.reactive.HeaderFiller", var10);
      Object[] var11 = new Object[]{var1};
      List var12 = Arrays.asList(var11);
      var8 = var8.property("io.quarkus.rest.client.invokedMethodParameters", var12);
      ClassLoader var13 = Thread.currentThread().getContextClassLoader();
      Type[] var14 = new Type[1];
      Class var15 = Class.forName("org.acme.rest.client.Extension", false, var13);
      var14[0] = var15;
      ParameterizedTypeImpl var16 = new ParameterizedTypeImpl(Set.class, var14);
      GenericType var17 = new GenericType((Type)var16);

      try {
         return ((CompletionStageRxInvoker)var8.async()).method("GET", var17);
      } catch (ProcessingException var20) {
         Throwable var19 = ((Throwable)var20).getCause();
         if (!(var19 instanceof RuntimeException)) {
            throw (Throwable)var20;
         } else {
            throw var19;
         }
      }
   }

   @Override
   public void close() {
      this.baseTarget.getRestClient().close();
   }
}

And yes, the class is thread safe, there is no state being held.

[paul-luk]

In your sample code, the instance of 'ExtensionsService$$QuarkusRestClientInterface', I see it make use of instance variables

WebTargetImpl baseTarget/target1/target2/target3;....

I assume you mean they are thread safe as well?

I don't see any javadocs indicating 'jakarta.ws.rs.client.WebTarget' / 'org.jboss.resteasy.reactive.client.impl.WebTargetImpl' are thread safe...
(Seems specification not clear.... ref: jakartaee/rest#494)

Anyway, if the generated TestRestService is thread safe (at least in quarkus framework), I can reuse the same 'TestRestService' instance in multiple thread (given that the base URI not changed).

Thank you for your advice.

[geoand]

WebTargetImpl baseTarget/target1/target2/target3;....

I assume you mean they are thread safe as well?

These are never changed, they are set in the constructor and subsequently they are only queried.

Anyway, if the generated TestRestService is thread safe (at least in quarkus framework), I can reuse the same 'TestRestService' instance in multiple thread (given that the base URI not changed

Yup, you indeed can

Thank you for your advice

🙏🏼