Better error message

quarkusio · Aug 5, 2021 · fda25f6 · fda25f6
1 parent 2a43b29
commit fda25f6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/...processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java b/...processor/src/main/java/org/jboss/resteasy/reactive/common/processor/EndpointIndexer.java
@@ -944,6 +944,8 @@ && isContextType(paramType.asClassType())) {
             } else if (!field && pathParameters.contains(sourceName)) {
                 builder.setName(sourceName);
                 builder.setType(ParameterType.PATH);
+                builder.setErrorLocation(builder.getErrorLocation()
+                        + " (this parameter name matches the @Path parameter name, so it has been implicitly assumed to be an @PathParam and not the request body)");
                 convertible = true;
             } else {
                 //un-annotated field

diff --git a/...sor/src/main/java/org/jboss/resteasy/reactive/server/processor/ServerEndpointIndexer.java b/...sor/src/main/java/org/jboss/resteasy/reactive/server/processor/ServerEndpointIndexer.java
@@ -269,8 +269,13 @@ elementType, toClassName(paramType, currentClassInfo, actualEndpointInfo, index)
 
     protected void handleOtherParam(Map<String, String> existingConverters, String errorLocation, boolean hasRuntimeConverters,
             ServerIndexedParameter builder, String elementType) {
-        builder.setConverter(extractConverter(elementType, index,
-                existingConverters, errorLocation, hasRuntimeConverters));
+        try {
+            builder.setConverter(extractConverter(elementType, index,
+                    existingConverters, errorLocation, hasRuntimeConverters));
+        } catch (Throwable throwable) {
+            throw new RuntimeException("Could not create converter for " + elementType + " for " + builder.getErrorLocation()
+                    + " of type " + builder.getType());
+        }
     }
 
     protected void handleSortedSetParam(Map<String, String> existingConverters, String errorLocation,