Merge pull request #30767 from Foobartender/#30681.2

Remove duplicate notification of SseBroadcaster's onErrorListeners
quarkusio · Feb 7, 2023 · e664271 · e664271
2 parents 97ca0fe + 5691787
commit e664271
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/...er/runtime/src/main/java/org/jboss/resteasy/reactive/server/jaxrs/SseBroadcasterImpl.java b/...er/runtime/src/main/java/org/jboss/resteasy/reactive/server/jaxrs/SseBroadcasterImpl.java
@@ -127,11 +127,4 @@ synchronized void fireClose(SseEventSinkImpl sseEventSink) {
             listener.accept(sseEventSink);
         }
     }
-
-    synchronized void fireException(SseEventSinkImpl sseEventSink, Throwable t) {
-        for (BiConsumer<SseEventSink, Throwable> listener : onErrorListeners) {
-            listener.accept(sseEventSink, t);
-        }
-    }
-
 }
diff --git a/...rver/runtime/src/main/java/org/jboss/resteasy/reactive/server/jaxrs/SseEventSinkImpl.java b/...rver/runtime/src/main/java/org/jboss/resteasy/reactive/server/jaxrs/SseEventSinkImpl.java
@@ -32,15 +32,7 @@ public CompletionStage<?> send(OutboundSseEvent event) {
         if (isClosed())
             throw new IllegalStateException("Already closed");
         // NOTE: we can't cast event to OutboundSseEventImpl because the TCK sends us its own subclass
-        CompletionStage<?> ret = SseUtil.send(context, event, Collections.emptyList());
-        if (broadcaster != null) {
-            return ret.whenComplete((value, x) -> {
-                if (x != null) {
-                    broadcaster.fireException(this, x);
-                }
-            });
-        }
-        return ret;
+        return SseUtil.send(context, event, Collections.emptyList());
     }
 
     @Override