Merge pull request #18940 from barreiro/leak-report

Expose Agroal feature: enhanced leak report
quarkusio · Aug 9, 2021 · e59b466 · e59b466
2 parents 56d4ae5 + 5062013
commit e59b466
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/...ns/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/AgroalEventLoggingListener.java b/...ns/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/AgroalEventLoggingListener.java
@@ -41,6 +41,11 @@ public void onConnectionCreation(Connection connection) {
         log.tracev("{0}: Created connection {1}", datasourceName, connection);
     }
 
+    @Override
+    public void onConnectionLeak(Connection connection, Thread thread) {
+        log.infov("{0}: Connection leak of {1}", datasourceName, connection);
+    }
+
     @Override
     public void onConnectionReap(Connection connection) {
         log.tracev("{0}: Closing idle connection {1}", datasourceName, connection);

diff --git a/...s/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java b/...s/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSourceJdbcRuntimeConfig.java
@@ -76,6 +76,12 @@ public class DataSourceJdbcRuntimeConfig {
     @ConfigItem
     public Optional<AgroalConnectionFactoryConfiguration.TransactionIsolation> transactionIsolationLevel = Optional.empty();
 
+    /**
+     * Collect and display extra troubleshooting info on leaked connections.
+     */
+    @ConfigItem
+    public boolean extendedLeakReport;
+
     /**
      * When enabled Agroal will be able to produce a warning when a connection is returned
      * to the pool without the application having closed all open statements.

diff --git a/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSources.java b/extensions/agroal/runtime/src/main/java/io/quarkus/agroal/runtime/DataSources.java
@@ -301,6 +301,7 @@ public boolean isValid(Connection connection) {
         if (dataSourceJdbcRuntimeConfig.maxLifetime.isPresent()) {
             poolConfiguration.maxLifetime(dataSourceJdbcRuntimeConfig.maxLifetime.get());
         }
+        poolConfiguration.enhancedLeakReport(dataSourceJdbcRuntimeConfig.extendedLeakReport);
     }
 
     public DataSourceBuildTimeConfig getDataSourceBuildTimeConfig(String dataSourceName) {