Skip to content

Commit

Permalink
Merge pull request #35838 from yrodiere/native-tests-json
Browse files Browse the repository at this point in the history
Make it more obvious in CONTRIBUTING.md that native-tests.json needs to be updated
  • Loading branch information
gsmet authored Sep 11, 2023
2 parents b52ac94 + 0d17ccf commit caaead4
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@ Be sure to test your pull request in:
1. Java mode
2. Native mode

Also, make sure that any native tests you add will actually get executed on CI.
In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which
are run in parallel. This means that each new integration test module needs to be configured explicitly
in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode.

## Setup

If you have not done so on this machine, you need to:
Expand Down Expand Up @@ -752,7 +757,7 @@ This project is an open source project, please act responsibly, be nice, polite
* The native integration test for my extension didn't run in the CI

In the interest of speeding up CI, the native build job `native-tests` have been split into multiple categories which
are run in parallel. This means that each new extension needs to be configured explicitly
are run in parallel. This means that each new integration test module needs to be configured explicitly
in [`native-tests.json`](.github/native-tests.json) to have its integration tests run in native mode.

* Build aborts complaining about missing (or superfluous) `minimal *-deployment dependencies`
Expand Down

0 comments on commit caaead4

Please sign in to comment.