Skip to content

Commit

Permalink
Merge pull request #44915 from holly-cummins/slightly-weaken-disablement
Browse files Browse the repository at this point in the history
Run classpath test on non-native paths
  • Loading branch information
yrodiere authored Dec 4, 2024
2 parents c5cc765 + f3de58e commit bedb080
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import static io.restassured.RestAssured.given;
import static org.hamcrest.Matchers.is;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import io.quarkus.test.junit.DisabledOnIntegrationTest;
Expand Down Expand Up @@ -53,9 +52,10 @@ public void testStaticInitMainResourceNoDuplicate() {
.body(is("OK"));
}

// For some reason, class files are not accessible as resources through the runtime init classloader;"
// that's beside the point of this PR though, so we'll ignore that."
@Test
@Disabled("For some reason, class files are not accessible as resources through the runtime init classloader;"
+ " that's beside the point of this PR though, so we'll ignore that.")
@DisabledOnIntegrationTest()
public void testRuntimeInitMainClassNoDuplicate() {
given().param("resourceName", CLASS_FILE)
.param("phase", "runtime_init")
Expand All @@ -65,6 +65,8 @@ public void testRuntimeInitMainClassNoDuplicate() {

@Test
public void testRuntimeInitMainResourceNoDuplicate() {
// Runtime classloader classes are stored in memory, as "quarkus:" resources, and we do not have a quarkus filesystem provider
// at the moment, the path helper works around that by hacking/reverse engineering a file-based location
given().param("resourceName", RESOURCE_FILE)
.param("phase", "runtime_init")
.when().get("/core/classpath").then()
Expand Down

0 comments on commit bedb080

Please sign in to comment.