Fix broken directory with space handling

Fixes: #8977

.github/workflows/ci-actions.yml

@@ -422,7 +422,7 @@ jobs:
               virtual-http
               rest-client
           - category: Misc1
-            timeout: 40
+            timeout: 45
             test-modules: >
               maven
               jackson
@@ -526,11 +526,16 @@ jobs:
       - name: Build with Maven
         env: 
           TEST_MODULES: ${{matrix.test-modules}}
+          CATEGORY: ${{matrix.category}}
         run: |
           for i in $TEST_MODULES
           do modules+=("integration-tests/$i"); done
           IFS=,
           eval mvn -pl "${modules[*]}" $NATIVE_TEST_MAVEN_OPTS
+          # add the 'simple with spaces' project to the run of 'Misc1' by cd-ing into the directory since Maven doesn't like having names with spaces on the command line
+          if [ "$CATEGORY" == "Misc1" ]; then
+            mvn -Dnative -Dquarkus.native.container-build=true -B --settings .github/mvn-settings.xml -f 'integration-tests/simple with space/' verify
+          fi
       - name: Prepare failure archive (if maven failed)
         if: failure()
         shell: bash

core/runtime/src/main/java/io/quarkus/runtime/util/ClassPathUtils.java

@@ -175,17 +175,21 @@ public static void consumeStream(URL url, Consumer<InputStream> consumer) throws
      */
     public static <R> R readStream(URL url, Function<InputStream, R> function) throws IOException {
         if (JAR.equals(url.getProtocol())) {
-            final URI uri;
-            try {
-                uri = new URI(url.toString());
-            } catch (URISyntaxException e) {
-                throw new IOException(e);
-            }
+            final URI uri = toURI(url);
             final String file = uri.getSchemeSpecificPart();
-            final int exclam = file.lastIndexOf('!');
-            final Path jar = toLocalPath(exclam >= 0 ? new URL(file.substring(0, exclam)) : url);
+            final int fileExclam = file.lastIndexOf('!');
+            final URL jarURL;
+            if (fileExclam > 0) {
+                // we need to use the original url instead of the scheme specific part because it contains the properly encoded path
+                String urlFile = url.getFile();
+                int urlExclam = urlFile.lastIndexOf('!');
+                jarURL = new URL(urlFile.substring(0, urlExclam));
+            } else {
+                jarURL = url;
+            }
+            final Path jar = toLocalPath(jarURL);
             try (FileSystem jarFs = FileSystems.newFileSystem(jar, (ClassLoader) null)) {
-                try (InputStream is = Files.newInputStream(jarFs.getPath(file.substring(exclam + 1)))) {
+                try (InputStream is = Files.newInputStream(jarFs.getPath(file.substring(fileExclam + 1)))) {
                     return function.apply(is);
                 }
             }
@@ -200,6 +204,16 @@ public static <R> R readStream(URL url, Function<InputStream, R> function) throw
         }
     }
 
+    private static URI toURI(URL url) throws IOException {
+        final URI uri;
+        try {
+            uri = new URI(url.toString());
+        } catch (URISyntaxException e) {
+            throw new IOException(e);
+        }
+        return uri;
+    }
+
     /**
      * Translates a URL to local file system path.
      * In case the the URL couldn't be translated to a file system path,

integration-tests/pom.xml

@@ -106,6 +106,7 @@
         <module>reactive-messaging-amqp</module>
         <module>rest-client</module>
         <module>packaging</module>
+        <module>simple with space</module>
     </modules>
 
     <build>

integration-tests/simple with space/pom.xml

@@ -0,0 +1,92 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>quarkus-integration-tests-parent</artifactId>
+        <groupId>io.quarkus</groupId>
+        <version>999-SNAPSHOT</version>
+        <relativePath>../</relativePath>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>quarkus-integration-test-simple-with-space</artifactId>
+    <name>Quarkus - Integration Tests - Simple with space</name>
+    <description>
+        A very basic integration test that contains a space in the directory and also resources files that contain spaces
+    </description>
+    <dependencies>
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-resteasy</artifactId>
+        </dependency>
+        <!-- added because /META-INF/resources/licenses/ contains files with spaces in their names -->
+        <dependency>
+            <groupId>org.primefaces</groupId>
+            <artifactId>primefaces</artifactId>
+            <version>8.0</version>
+        </dependency>
+
+        <dependency>
+            <groupId>io.quarkus</groupId>
+            <artifactId>quarkus-junit5</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>io.rest-assured</groupId>
+            <artifactId>rest-assured</artifactId>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>io.quarkus</groupId>
+                <artifactId>quarkus-maven-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>build</goal>
+                        </goals>
+                    </execution>
+                </executions>
+            </plugin>
+        </plugins>
+    </build>
+
+    <profiles>
+        <profile>
+            <id>native</id>
+            <activation>
+                <property>
+                    <name>native</name>
+                </property>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-failsafe-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <goals>
+                                    <goal>integration-test</goal>
+                                    <goal>verify</goal>
+                                </goals>
+                                <configuration>
+                                    <systemProperties>
+                                        <native.image.path>${project.build.directory}/${project.build.finalName}-runner</native.image.path>
+                                    </systemProperties>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+            <properties>
+                <quarkus.package.type>native</quarkus.package.type>
+            </properties>
+        </profile>
+    </profiles>
+
+</project>

integration-tests/simple with space/src/main/java/io/quarkus/it/spaces/GreetingResource.java

@@ -0,0 +1,21 @@
+package io.quarkus.it.spaces;
+
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.Produces;
+import javax.ws.rs.core.MediaType;
+
+import org.primefaces.util.Constants;
+
+@Path("/hello")
+public class GreetingResource {
+
+    // make sure we reference something from Primefaces so GraalVM doesn't throw out the entire jar
+    private static final String PRIMEFACES_DOWNLOAD_COOKIE = Constants.DOWNLOAD_COOKIE;
+
+    @GET
+    @Produces(MediaType.TEXT_PLAIN)
+    public String hello() {
+        return "hello";
+    }
+}

integration-tests/simple with space/src/test/java/io/quarkus/it/spaces/GreetingResourceTest.java

@@ -0,0 +1,22 @@
+package io.quarkus.it.spaces;
+
+import static io.restassured.RestAssured.given;
+import static org.hamcrest.CoreMatchers.is;
+
+import org.junit.jupiter.api.Test;
+
+import io.quarkus.test.junit.QuarkusTest;
+
+@QuarkusTest
+public class GreetingResourceTest {
+
+    @Test
+    public void testHelloEndpoint() {
+        given()
+                .when().get("/hello")
+                .then()
+                .statusCode(200)
+                .body(is("hello"));
+    }
+
+}

integration-tests/simple with space/src/test/java/io/quarkus/it/spaces/NativeGreetingResourceIT.java

@@ -0,0 +1,9 @@
+package io.quarkus.it.spaces;
+
+import io.quarkus.test.junit.NativeImageTest;
+
+@NativeImageTest
+public class NativeGreetingResourceIT extends GreetingResourceTest {
+
+    // Execute the same tests but in native mode.
+}