-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Taking into account the
@Priority annotation in context providers
At the moment, users can register multiple context providers for handing the same class by using:
```java
Client client = QuarkusRestClientBuilder.newBuilder()
.baseUri(URI.create(uri))
.register(MyLowPriorityContextProvider.class)
.register(MyHighPriorityContextProvider.class)
.build(Client.class);
```
When doing this, REST Client Reactive will always return the first registered context provider for the matching type:
```java
@priority(2)
public static class MyLowPriorityContextProvider implements ContextResolver<Person> {
@OverRide
public Person getContext(Class<?> aClass) {
// ...
}
}
@priority(1)
public static class MyHighPriorityContextProvider implements ContextResolver<Person> {
@OverRide
public Person getContext(Class<?> aClass) {
// ...
}
}
```
With these changes, the `@Priority` annotation is taking into account to return the correct context provider regardless to when it has been registered.- Loading branch information
Showing
2 changed files
with
139 additions
and
13 deletions.
There are no files selected for viewing
120 changes: 120 additions & 0 deletions
120
.../src/test/java/io/quarkus/rest/client/reactive/provider/ContextProvidersPriorityTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| package io.quarkus.rest.client.reactive.provider; | ||
|
|
||
| import static io.restassured.RestAssured.given; | ||
| import static java.lang.String.format; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import java.net.URI; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import jakarta.annotation.Priority; | ||
| import jakarta.enterprise.context.ApplicationScoped; | ||
| import jakarta.ws.rs.GET; | ||
| import jakarta.ws.rs.POST; | ||
| import jakarta.ws.rs.Path; | ||
| import jakarta.ws.rs.Produces; | ||
| import jakarta.ws.rs.core.Context; | ||
| import jakarta.ws.rs.core.HttpHeaders; | ||
| import jakarta.ws.rs.core.MultivaluedHashMap; | ||
| import jakarta.ws.rs.core.MultivaluedMap; | ||
| import jakarta.ws.rs.ext.ContextResolver; | ||
|
|
||
| import org.eclipse.microprofile.rest.client.ext.ClientHeadersFactory; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.extension.RegisterExtension; | ||
|
|
||
| import io.quarkus.rest.client.reactive.QuarkusRestClientBuilder; | ||
| import io.quarkus.rest.client.reactive.TestJacksonBasicMessageBodyReader; | ||
| import io.quarkus.test.QuarkusUnitTest; | ||
| import io.quarkus.test.common.http.TestHTTPResource; | ||
|
|
||
| public class ContextProvidersPriorityTest { | ||
| private static final String HEADER_NAME = "my-header"; | ||
| private static final String HEADER_VALUE_FROM_LOW_PRIORITY = "low-priority"; | ||
| private static final String HEADER_VALUE_FROM_HIGH_PRIORITY = "high-priority"; | ||
|
|
||
| @TestHTTPResource | ||
| URI baseUri; | ||
|
|
||
| @RegisterExtension | ||
| static final QuarkusUnitTest config = new QuarkusUnitTest() | ||
| .withApplicationRoot((jar) -> jar.addClasses(Client.class, TestJacksonBasicMessageBodyReader.class)); | ||
|
|
||
| @Test | ||
| void shouldUseTheHighestPriorityContextProvider() { | ||
| // @formatter:off | ||
| var response = | ||
| given() | ||
| .body(baseUri.toString()) | ||
| .when() | ||
| .post("/call-client") | ||
| .thenReturn(); | ||
| // @formatter:on | ||
| assertThat(response.statusCode()).isEqualTo(200); | ||
| assertThat(response.jsonPath().getString(HEADER_NAME)).isEqualTo(format("[%s]", HEADER_VALUE_FROM_HIGH_PRIORITY)); | ||
| } | ||
|
|
||
| @Path("/") | ||
| @ApplicationScoped | ||
| public static class Resource { | ||
|
|
||
| @GET | ||
| @Produces("application/json") | ||
| public Map<String, List<String>> returnHeaderValues(@Context HttpHeaders headers) { | ||
| return headers.getRequestHeaders(); | ||
| } | ||
|
|
||
| @Path("/call-client") | ||
| @POST | ||
| public Map<String, List<String>> callClient(String uri) { | ||
| Client client = QuarkusRestClientBuilder.newBuilder() | ||
| .baseUri(URI.create(uri)) | ||
| .register(LowPriorityClientHeadersProvider.class) | ||
| .register(HighPriorityClientHeadersProvider.class) | ||
| .register(new TestJacksonBasicMessageBodyReader()) | ||
| .build(Client.class); | ||
| return client.get(); | ||
| } | ||
| } | ||
|
|
||
| public interface Client { | ||
| @GET | ||
| Map<String, List<String>> get(); | ||
| } | ||
|
|
||
| @Priority(2) | ||
| public static class LowPriorityClientHeadersProvider implements ContextResolver<ClientHeadersFactory> { | ||
|
|
||
| @Override | ||
| public ClientHeadersFactory getContext(Class<?> aClass) { | ||
| return new CustomClientHeadersFactory(HEADER_VALUE_FROM_LOW_PRIORITY); | ||
| } | ||
| } | ||
|
|
||
| @Priority(1) | ||
| public static class HighPriorityClientHeadersProvider implements ContextResolver<ClientHeadersFactory> { | ||
|
|
||
| @Override | ||
| public ClientHeadersFactory getContext(Class<?> aClass) { | ||
| return new CustomClientHeadersFactory(HEADER_VALUE_FROM_HIGH_PRIORITY); | ||
| } | ||
| } | ||
|
|
||
| public static class CustomClientHeadersFactory implements ClientHeadersFactory { | ||
|
|
||
| private final String value; | ||
|
|
||
| public CustomClientHeadersFactory(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| @Override | ||
| public MultivaluedMap<String, String> update(MultivaluedMap<String, String> multivaluedMap, | ||
| MultivaluedMap<String, String> multivaluedMap1) { | ||
| MultivaluedHashMap<String, String> newHeaders = new MultivaluedHashMap<>(); | ||
| newHeaders.add(HEADER_NAME, value); | ||
| return newHeaders; | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters