Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Guillaume Smet <[email protected]>
  • Loading branch information
stuartwdouglas and gsmet authored Feb 21, 2021
1 parent 366a9b4 commit af8ecf2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/src/main/asciidoc/datasource.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ quarkus.datasource.jdbc.url=jdbc:postgresql://localhost:5432/hibernate_orm_test
quarkus.datasource.jdbc.max-size=16
----
<1> If you only have a single JDBC extension, or you are running tests and only have a single test scoped JDBC extension installed then this is
optional. If there is only once possible extension we assume this is the correct one, and if a driver has been added with test scope then
optional. If there is only one possible extension we assume this is the correct one, and if a driver has been added with test scope then
we assume that this should be used in testing.

=== Reactive datasource
Expand All @@ -83,7 +83,7 @@ Then configure your reactive datasource:

[source, properties]
----
quarkus.datasource.db-kind=postgresql<1>
quarkus.datasource.db-kind=postgresql <1>
quarkus.datasource.username=<your username>
quarkus.datasource.password=<your password>
Expand Down Expand Up @@ -403,7 +403,7 @@ quarkus.datasource.inventory.jdbc.max-size=12
Notice there is an extra bit in the key.
The syntax is as follows: `quarkus.datasource.[optional name.][datasource property]`.

NOTE: Even when only one database extension is installed named databases need to specify at least one build time
NOTE: Even when only one database extension is installed, named databases need to specify at least one build time
property so that Quarkus knows they exist. Generally this will be the `db-kind` property, although you can also
specify DevServices properties to create named datasources (covered later in this guide).

Expand Down Expand Up @@ -463,7 +463,7 @@ You can override this by setting the `transactions` configuration property - see
== DevDb (Configuration Free Databases)

As mentioned above Quarkus supports a feature called DevServices that allows you to create datasources without any config. If
you have a database extension that supports it and no config is provided Quarkus will automatically start a database (either
you have a database extension that supports it and no config is provided, Quarkus will automatically start a database (either
using Testcontainers, or by starting a Java DB in process), and automatically configure a connection to this database.

Production databases need to be configured as normal, so if you want to include a production database config in your
Expand Down

0 comments on commit af8ecf2

Please sign in to comment.