Merge pull request #37611 from yrodiere/i37610

Fix configuration of custom port for Elasticsearch dev services
quarkusio · Dec 8, 2023 · af6d3d7 · af6d3d7
2 parents 0d90b7c + 442ab5c
commit af6d3d7
Show file tree

Hide file tree

Showing 3 changed files with 55 additions and 1 deletion.
diff --git a/...quarkus/elasticsearch/restclient/common/deployment/DevServicesElasticsearchProcessor.java b/...quarkus/elasticsearch/restclient/common/deployment/DevServicesElasticsearchProcessor.java
@@ -220,7 +220,7 @@ private DevServicesResultBuildItem.RunningDevService startElasticsearch(
                 container.withLabel(DEV_SERVICE_LABEL, config.serviceName);
             }
             if (config.port.isPresent()) {
-                container.setPortBindings(List.of(config.port.get() + ":" + config.port.get()));
+                container.setPortBindings(List.of(config.port.get() + ":" + ELASTICSEARCH_PORT));
             }
             timeout.ifPresent(container::withStartupTimeout);
 

diff --git a/...search/restclient/lowlevel/runtime/DevServicesElasticsearchDevModeCustomPortTestCase.java b/...search/restclient/lowlevel/runtime/DevServicesElasticsearchDevModeCustomPortTestCase.java
@@ -0,0 +1,47 @@
+package io.quarkus.elasticsearch.restclient.lowlevel.runtime;
+
+import static org.hamcrest.Matchers.endsWith;
+import static org.hamcrest.Matchers.equalTo;
+
+import org.jboss.shrinkwrap.api.asset.StringAsset;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusDevModeTest;
+import io.restassured.RestAssured;
+
+public class DevServicesElasticsearchDevModeCustomPortTestCase {
+    @RegisterExtension
+    static QuarkusDevModeTest test = new QuarkusDevModeTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClass(TestResource.class)
+                    .addAsResource(new StringAsset("""
+                            quarkus.elasticsearch.devservices.port=19200
+                            """), "application.properties"));
+
+    @Test
+    public void checkConfiguredPort() {
+        RestAssured
+                .when().get("/fruits/configured-hosts")
+                .then().body(endsWith(":19200"));
+
+    }
+
+    @Test
+    public void testDatasource() throws Exception {
+        var fruit = new TestResource.Fruit();
+        fruit.id = "1";
+        fruit.name = "banana";
+        fruit.color = "yellow";
+
+        RestAssured
+                .given().body(fruit).contentType("application/json")
+                .when().post("/fruits")
+                .then().statusCode(204);
+
+        RestAssured.when().get("/fruits/search?term=color&match=yellow")
+                .then()
+                .statusCode(200)
+                .body(equalTo("[{\"id\":\"1\",\"name\":\"banana\",\"color\":\"yellow\"}]"));
+    }
+}
diff --git a/...ment/src/test/java/io/quarkus/elasticsearch/restclient/lowlevel/runtime/TestResource.java b/...ment/src/test/java/io/quarkus/elasticsearch/restclient/lowlevel/runtime/TestResource.java
@@ -11,6 +11,7 @@
 import jakarta.ws.rs.QueryParam;
 
 import org.apache.http.util.EntityUtils;
+import org.eclipse.microprofile.config.ConfigProvider;
 import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.RestClient;
@@ -57,6 +58,12 @@ public List<Fruit> search(@QueryParam("term") String term, @QueryParam("match")
         return results;
     }
 
+    @GET
+    @Path("/configured-hosts")
+    public String configuredHosts() {
+        return ConfigProvider.getConfig().getConfigValue("quarkus.elasticsearch.hosts").getValue();
+    }
+
     public static class Fruit {
         public String id;
         public String name;