Merge pull request #41793 from turing85/feature/parmeters-in-compile-…

…plugin Use <parameters>true</parameters> instead of <compilerArgs><arg>-parameters</arg></compilerArgs>
quarkusio · Jul 10, 2024 · aaf2960 · aaf2960
2 parents 6fe7d62 + ef216fe
commit aaf2960
Show file tree

Hide file tree

Showing 60 changed files with 60 additions and 181 deletions.
diff --git a/docs/src/main/asciidoc/building-my-first-extension.adoc b/docs/src/main/asciidoc/building-my-first-extension.adoc
@@ -219,9 +219,7 @@ Your extension is a multi-module project. So let's start by checking out the par
           <artifactId>maven-compiler-plugin</artifactId>
           <version>${compiler-plugin.version}</version>
           <configuration>
-            <compilerArgs>
-              <arg>-parameters</arg><!--5-->
-            </compilerArgs>
+            <parameters>true</parameters>
           </configuration>
         </plugin>
       </plugins>
@@ -234,7 +232,6 @@ Your extension is a multi-module project. So let's start by checking out the par
 <2> Quarkus requires a recent version of the Maven compiler plugin supporting the annotationProcessorPaths configuration.
 <3> The `quarkus-bom` aligns your dependencies with those used by Quarkus during the augmentation phase.
 <4> Quarkus requires these configs to run tests properly.
-<5> Setting the `parameters` flag this way works around https://issues.apache.org/jira/browse/MCOMPILER-413[MCOMPILER-413].
 
 ==== The Deployment module
 

diff --git a/extensions/tls-registry/cli/pom.xml b/extensions/tls-registry/cli/pom.xml
@@ -37,9 +37,7 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...src/main/resources/codestarts/quarkus-extension/code/extension-base/java/pom.tpl.qute.xml b/...src/main/resources/codestarts/quarkus-extension/code/extension-base/java/pom.tpl.qute.xml
@@ -113,9 +113,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>$\{compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 {/if}

diff --git a/...se-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/base/pom.tpl.qute.xml b/...se-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/base/pom.tpl.qute.xml
@@ -152,9 +152,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>$\{compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <!-- Run the tests in JVM mode -->

diff --git a/...g/src/test/resources/__snapshots__/QuarkusCodestartGenerationTest/generateDefault/pom.xml b/...g/src/test/resources/__snapshots__/QuarkusCodestartGenerationTest/generateDefault/pom.xml
@@ -63,9 +63,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...resources/__snapshots__/QuarkusCodestartGenerationTest/generateMavenWithCustomDep/pom.xml b/...resources/__snapshots__/QuarkusCodestartGenerationTest/generateMavenWithCustomDep/pom.xml
@@ -78,9 +78,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...rc/test/resources/__snapshots__/KotlinSerializationCodestartTest/testMavenContent/pom.xml b/...rc/test/resources/__snapshots__/KotlinSerializationCodestartTest/testMavenContent/pom.xml
@@ -92,9 +92,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/integration-tests/hibernate-orm-compatibility-5.6/database-generator/pom.xml b/integration-tests/hibernate-orm-compatibility-5.6/database-generator/pom.xml
@@ -67,9 +67,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...aven/src/test/resources-filtered/expected/new-extension-current-directory-project/pom.xml b/...aven/src/test/resources-filtered/expected/new-extension-current-directory-project/pom.xml
@@ -42,9 +42,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
             </plugins>

diff --git a/...ion-tests/maven/src/test/resources-filtered/expected/new-extension-project/my-ext/pom.xml b/...ion-tests/maven/src/test/resources-filtered/expected/new-extension-project/my-ext/pom.xml
@@ -42,9 +42,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
             </plugins>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/codegen-config-factory/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/codegen-config-factory/pom.xml
@@ -67,9 +67,7 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>\${compiler-plugin.version}</version>
           <configuration>
-            <compilerArgs>
-              <arg>-parameters</arg>
-            </compilerArgs>
+            <parameters>true</parameters>
           </configuration>
         </plugin>
         <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/config-tracking/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/config-tracking/pom.xml
@@ -59,9 +59,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
     </plugins>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/extension-codestart/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/extension-codestart/pom.xml
@@ -41,9 +41,7 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>\${compiler-plugin.version}</version>
           <configuration>
-            <compilerArgs>
-              <arg>-parameters</arg>
-            </compilerArgs>
+            <parameters>true</parameters>
           </configuration>
         </plugin>
       </plugins>

diff --git a/.../maven/src/test/resources-filtered/projects/extension-removed-resources/extension/pom.xml b/.../maven/src/test/resources-filtered/projects/extension-removed-resources/extension/pom.xml
@@ -26,9 +26,7 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>\${compiler-plugin.version}</version>
           <configuration>
-            <compilerArgs>
-              <arg>-parameters</arg>
-            </compilerArgs>
+            <parameters>true</parameters>
           </configuration>
         </plugin>
       </plugins>

diff --git a/.../maven/src/test/resources-filtered/projects/extension-removed-resources/resources/pom.xml b/.../maven/src/test/resources-filtered/projects/extension-removed-resources/resources/pom.xml
@@ -14,9 +14,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
     </plugins>

diff --git a/...sts/maven/src/test/resources-filtered/projects/extension-removed-resources/runner/pom.xml b/...sts/maven/src/test/resources-filtered/projects/extension-removed-resources/runner/pom.xml
@@ -47,9 +47,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/...n/src/test/resources-filtered/projects/extension-removed-resources/service-loader/pom.xml b/...n/src/test/resources-filtered/projects/extension-removed-resources/service-loader/pom.xml
@@ -14,9 +14,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
     </plugins>

diff --git a/...c/test/resources-filtered/projects/extension-removed-resources/subatomic-provider/pom.xml b/...c/test/resources-filtered/projects/extension-removed-resources/subatomic-provider/pom.xml
@@ -21,9 +21,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
     </plugins>

diff --git a/.../test/resources-filtered/projects/extension-removed-resources/supersonic-provider/pom.xml b/.../test/resources-filtered/projects/extension-removed-resources/supersonic-provider/pom.xml
@@ -21,9 +21,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
     </plugins>

diff --git a/...tion-tests/maven/src/test/resources-filtered/projects/extension-test-with-no-main/pom.xml b/...tion-tests/maven/src/test/resources-filtered/projects/extension-test-with-no-main/pom.xml
@@ -66,9 +66,7 @@
           <artifactId>maven-compiler-plugin</artifactId>
           <version>\${compiler-plugin.version}</version>
           <configuration>
-            <compilerArgs>
-              <arg>-parameters</arg>
-            </compilerArgs>
+            <parameters>true</parameters>
           </configuration>
         </plugin>
       </plugins>

diff --git a/...ests/maven/src/test/resources-filtered/projects/external-reloadable-artifacts/app/pom.xml b/...ests/maven/src/test/resources-filtered/projects/external-reloadable-artifacts/app/pom.xml
@@ -51,9 +51,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>\${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...n/src/test/resources-filtered/projects/external-reloadable-artifacts/external-lib/pom.xml b/...n/src/test/resources-filtered/projects/external-reloadable-artifacts/external-lib/pom.xml
@@ -21,9 +21,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>\${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/ignore-entries-uber-jar/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/ignore-entries-uber-jar/pom.xml
@@ -45,9 +45,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/modules-in-profiles/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/modules-in-profiles/pom.xml
@@ -29,9 +29,7 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>\${compiler-plugin.version}</version>
                 <configuration>
-                    <compilerArgs>
-                        <arg>-parameters</arg>
-                    </compilerArgs>
+                    <parameters>true</parameters>
                 </configuration>
             </plugin>
             <plugin>

diff --git a/...sts/maven/src/test/resources-filtered/projects/multi-build-mode-parallel/module-1/pom.xml b/...sts/maven/src/test/resources-filtered/projects/multi-build-mode-parallel/module-1/pom.xml
@@ -19,9 +19,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/...sts/maven/src/test/resources-filtered/projects/multi-build-mode-parallel/module-2/pom.xml b/...sts/maven/src/test/resources-filtered/projects/multi-build-mode-parallel/module-2/pom.xml
@@ -19,9 +19,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/multi-build-mode/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/multi-build-mode/pom.xml
@@ -65,9 +65,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/multijar-module/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/multijar-module/pom.xml
@@ -35,9 +35,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/multimodule-classpath/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/multimodule-classpath/pom.xml
@@ -33,9 +33,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 <plugin>

diff --git a/...ration-tests/maven/src/test/resources-filtered/projects/multimodule-revision-prop/pom.xml b/...ration-tests/maven/src/test/resources-filtered/projects/multimodule-revision-prop/pom.xml
@@ -33,9 +33,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/multimodule-root-no-src/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/multimodule-root-no-src/pom.xml
@@ -32,9 +32,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/multimodule/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/multimodule/pom.xml
@@ -32,9 +32,7 @@
                     <artifactId>maven-compiler-plugin</artifactId>
                     <version>\${compiler-plugin.version}</version>
                     <configuration>
-                        <compilerArgs>
-                            <arg>-parameters</arg>
-                        </compilerArgs>
+                        <parameters>true</parameters>
                     </configuration>
                 </plugin>
                 <plugin>

diff --git a/...gration-tests/maven/src/test/resources-filtered/projects/native-agent-integration/pom.xml b/...gration-tests/maven/src/test/resources-filtered/projects/native-agent-integration/pom.xml
@@ -50,9 +50,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/native-image-app/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/native-image-app/pom.xml
@@ -39,9 +39,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>

diff --git a/integration-tests/maven/src/test/resources-filtered/projects/no-resource-root/pom.xml b/integration-tests/maven/src/test/resources-filtered/projects/no-resource-root/pom.xml
@@ -40,9 +40,7 @@
         <artifactId>maven-compiler-plugin</artifactId>
         <version>\${compiler-plugin.version}</version>
         <configuration>
-          <compilerArgs>
-            <arg>-parameters</arg>
-          </compilerArgs>
+          <parameters>true</parameters>
         </configuration>
       </plugin>
       <plugin>