Merge pull request #41824 from geoand/#41811

Properly close AsyncFile in Quarkus REST
quarkusio · Jul 11, 2024 · 929c697 · 929c697
2 parents dbced0b + a010cbd
commit 929c697
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...ss/resteasy/reactive/server/vertx/serializers/ServerMutinyAsyncFileMessageBodyWriter.java b/...ss/resteasy/reactive/server/vertx/serializers/ServerMutinyAsyncFileMessageBodyWriter.java
@@ -65,7 +65,9 @@ public void writeResponse(AsyncFile file, Type genericType, ServerRequestContext
         file.endHandler(new Runnable() {
             @Override
             public void run() {
-                file.close();
+                // we don't need to wait for the file to be closed, we just need to make sure it does get closed
+                //noinspection ResultOfMethodCallIgnored
+                file.close().subscribeAsCompletionStage();
                 response.end();
                 // Not sure if I need to resume, actually
                 ctx.resume();