Skip to content

Commit

Permalink
Merge pull request #41715 from holly-cummins/tidy-obsolete-comments
Browse files Browse the repository at this point in the history
Trivial: tidy comments which are no longer applicable
  • Loading branch information
gsmet authored Jul 6, 2024
2 parents 91abd83 + 9e8032c commit 8a9ec14
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ public void testParameterResolver(UnusedBean.DummyInput dummyInput, Matcher<Stri
private static Collection<Arguments> provideDummyInput() {
return List.of(
Arguments.of(
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.DummyInput("whatever",
new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3)))),
CoreMatchers.is("whatever/6")),
Arguments.of(
// note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.DummyInput("hi", new UnusedBean.NestedDummyInput(new ArrayList<>())),
CoreMatchers.is("hi/0")));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
@Override
public Object resolveParameter(ParameterContext parameterContext,
ExtensionContext extensionContext) throws ParameterResolutionException {
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
return new UnusedBean.DummyInput("whatever", new UnusedBean.NestedDummyInput(new ArrayList<>(List.of(1, 2, 3))));
}
}
Expand All @@ -78,7 +77,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
throws ParameterResolutionException {
return (Supplier<UnusedBean.DummyInput>) () -> new UnusedBean.DummyInput("fromSupplier",
// note: Collections.emptyList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
new UnusedBean.NestedDummyInput(new ArrayList<>()));
}
}
Expand Down Expand Up @@ -109,7 +107,6 @@ public boolean supportsParameter(ParameterContext parameterContext, ExtensionCon
@Override
public Object resolveParameter(ParameterContext parameterContext, ExtensionContext extensionContext)
throws ParameterResolutionException {
// note: List.of(...) or Arrays.asList() fails on Java 16 due to: https://github.com/x-stream/xstream/issues/253
return new ArrayList<>(List.of(new NonSerializable("foo"), new NonSerializable("bar")));
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@
/**
* Exercise {@link ParameterizedTest @ParameterizedTest}s.
*
* <p>
* This test will run into <a href="https://github.com/x-stream/xstream/issues/253">x-stream/xstream#253</a> on Java 16 and
* newer if the custom XStream converters are not used
*/
@QuarkusTest
public class ParamsTest {
Expand Down

0 comments on commit 8a9ec14

Please sign in to comment.