Micrometer: use method for generated mp gauge obj

quarkusio · Sep 16, 2021 · 726327e · 726327e
1 parent 67b5f67
commit 726327e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/...c/main/java/io/quarkus/micrometer/deployment/binder/mpmetrics/GaugeAnnotationHandler.java b/...c/main/java/io/quarkus/micrometer/deployment/binder/mpmetrics/GaugeAnnotationHandler.java
@@ -47,7 +47,8 @@ static void processAnnotatedGauges(IndexView index, ClassOutput classOutput) {
             verifyGaugeScope(target, classInfo);
 
             // Create a GaugeAdapter bean that uses the instance of the bean and invokes the callback
-            final String generatedClassName = classInfo.name().toString() + "_GaugeAdapter";
+            final String generatedClassName = String.format("%s_%s_GaugeAdapter",
+                    classInfo.name().toString(), methodInfo.name().toString());
             if (createdClasses.add(generatedClassName)) {
                 createClass(index, classOutput, generatedClassName, annotation, target, classInfo, methodInfo);
             }

diff --git a/...micrometer-mp-metrics/src/main/java/io/quarkus/it/micrometer/mpmetrics/PrimeResource.java b/...micrometer-mp-metrics/src/main/java/io/quarkus/it/micrometer/mpmetrics/PrimeResource.java
@@ -73,4 +73,9 @@ String checkPrime(long number) {
     public Long highestPrimeNumberSoFar() {
         return highestPrimeSoFar.get();
     }
+
+    @Gauge(unit = MetricUnits.NONE, description = "Highest prime number so far.")
+    public Long highestPrimeNumberSoFar2() {
+        return highestPrimeSoFar.get();
+    }
 }
diff --git a/...micrometer-mp-metrics/src/test/java/io/quarkus/it/micrometer/mpmetrics/MPMetricsTest.java b/...micrometer-mp-metrics/src/test/java/io/quarkus/it/micrometer/mpmetrics/MPMetricsTest.java
@@ -66,6 +66,8 @@ void validateMetricsOutput_1() {
                         "io_quarkus_it_micrometer_mpmetrics_CountedInstance_countPrimes_total{scope=\"application\",} 2.0"))
                 .body(containsString(
                         "highestPrimeNumberSoFar 887.0"))
+                .body(containsString(
+                        "io_quarkus_it_micrometer_mpmetrics_PrimeResource_highestPrimeNumberSoFar2{scope=\"application\",} 887.0"))
 
                 // the counter associated with a timed method should have been removed
                 .body(not(containsString("io_quarkus_it_micrometer_mpmetrics_PrimeResource_checkPrime")));