Create tar file in an atomic operation before uploading it to OpenShift

quarkusio · Mar 2, 2023 · 401fc01 · 401fc01
1 parent b69523b
commit 401fc01
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...ent/src/main/java/io/quarkus/container/image/openshift/deployment/OpenshiftProcessor.java b/...ent/src/main/java/io/quarkus/container/image/openshift/deployment/OpenshiftProcessor.java
@@ -361,10 +361,11 @@ public static void createContainerImage(KubernetesClientBuilder kubernetesClient
 
         File tar;
         try {
+            System.out.println("NEW!! 1");
             File original = Packaging.packageFile(output, base, additional);
             //Let's rename the archive and give it a more descriptive name, as it may appear in the logs.
             tar = Files.createTempFile("quarkus-", "-openshift").toFile();
-            Files.move(original.toPath(), tar.toPath(), StandardCopyOption.REPLACE_EXISTING);
+            Files.move(original.toPath(), tar.toPath(), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.ATOMIC_MOVE);
         } catch (Exception e) {
             throw new RuntimeException("Error creating the openshift binary build archive.", e);
         }

diff --git a/...-s2i/deployment/src/main/java/io/quarkus/container/image/s2i/deployment/S2iProcessor.java b/...-s2i/deployment/src/main/java/io/quarkus/container/image/s2i/deployment/S2iProcessor.java
@@ -268,7 +268,7 @@ public static void createContainerImage(KubernetesClient kubernetesClient,
             File original = PackageUtil.packageFile(output, additional);
             //Let's rename the archive and give it a more descriptive name, as it may appear in the logs.
             tar = Files.createTempFile("quarkus-", "-s2i").toFile();
-            Files.move(original.toPath(), tar.toPath(), StandardCopyOption.REPLACE_EXISTING);
+            Files.move(original.toPath(), tar.toPath(), StandardCopyOption.REPLACE_EXISTING, StandardCopyOption.ATOMIC_MOVE);
         } catch (Exception e) {
             throw new RuntimeException("Error creating the s2i binary build archive.", e);
         }