Add default to http max chunk size

quarkusio · Jul 9, 2020 · 31ec1f3 · 31ec1f3
1 parent 0e0457c
commit 31ec1f3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/...ns/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ServerLimitsConfig.java b/...ns/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/ServerLimitsConfig.java
@@ -23,8 +23,8 @@ public class ServerLimitsConfig {
     /**
      * The max HTTP chunk size
      */
-    @ConfigItem
-    public Optional<MemorySize> maxChunkSize;
+    @ConfigItem(defaultValue = "8192")
+    public MemorySize maxChunkSize;
 
     /**
      * The maximum length of the initial line (e.g. {@code "GET / HTTP/1.0"}).

diff --git a/...ons/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java b/...ons/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
@@ -547,10 +547,7 @@ private static HttpServerOptions createSslOptions(HttpBuildTimeConfig buildTimeC
             }
         }
         serverOptions.setMaxHeaderSize(httpConfiguration.limits.maxHeaderSize.asBigInteger().intValueExact());
-        Optional<MemorySize> maxChunkSize = httpConfiguration.limits.maxChunkSize;
-        if (maxChunkSize.isPresent()) {
-            serverOptions.setMaxChunkSize(maxChunkSize.get().asBigInteger().intValueExact());
-        }
+        serverOptions.setMaxChunkSize(httpConfiguration.limits.maxChunkSize.asBigInteger().intValueExact());
         setIdleTimeout(httpConfiguration, serverOptions);
 
         if (certFile.isPresent() && keyFile.isPresent()) {
@@ -708,10 +705,7 @@ private static HttpServerOptions createHttpServerOptions(HttpConfiguration httpC
         options.setPort(httpConfiguration.determinePort(launchMode));
         setIdleTimeout(httpConfiguration, options);
         options.setMaxHeaderSize(httpConfiguration.limits.maxHeaderSize.asBigInteger().intValueExact());
-        Optional<MemorySize> maxChunkSize = httpConfiguration.limits.maxChunkSize;
-        if (maxChunkSize.isPresent()) {
-            options.setMaxChunkSize(maxChunkSize.get().asBigInteger().intValueExact());
-        }
+        options.setMaxChunkSize(httpConfiguration.limits.maxChunkSize.asBigInteger().intValueExact());
         options.setWebsocketSubProtocols(websocketSubProtocols);
         options.setReusePort(httpConfiguration.soReusePort);
         options.setTcpQuickAck(httpConfiguration.tcpQuickAck);
@@ -730,10 +724,7 @@ private static HttpServerOptions createDomainSocketOptions(HttpConfiguration htt
         options.setHost(httpConfiguration.domainSocket);
         setIdleTimeout(httpConfiguration, options);
         options.setMaxHeaderSize(httpConfiguration.limits.maxHeaderSize.asBigInteger().intValueExact());
-        Optional<MemorySize> maxChunkSize = httpConfiguration.limits.maxChunkSize;
-        if (maxChunkSize.isPresent()) {
-            options.setMaxChunkSize(maxChunkSize.get().asBigInteger().intValueExact());
-        }
+        options.setMaxChunkSize(httpConfiguration.limits.maxChunkSize.asBigInteger().intValueExact());
         options.setWebsocketSubProtocols(websocketSubProtocols);
         return options;
     }