Merge pull request #30490 from gsmet/fix-self-suppression

Avoid adding the exception itself as a suppressed exception
quarkusio · Jan 20, 2023 · 2369fb1 · 2369fb1
2 parents 051f0c5 + cec7cd3
commit 2369fb1
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java b/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java
@@ -816,8 +816,13 @@ public void interceptTestMethod(Invocation<Void> invocation, ReflectiveInvocatio
             runExtensionMethod(invocationContext, extensionContext, true);
             invocation.skip();
         } catch (Throwable t) {
-            for (var i : serverExceptions) {
-                t.addSuppressed(i);
+            for (var serverException : serverExceptions) {
+                if (t == serverException) {
+                    // do not add a suppressed exception to itself
+                    continue;
+                }
+
+                t.addSuppressed(serverException);
             }
             throw t;
         } finally {