Do not override the container image name with Openshift configuration

quarkusio · Aug 2, 2023 · 154221b · 154221b
1 parent c00eb29
commit 154221b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/...vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftProcessor.java b/...vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftProcessor.java
@@ -40,7 +40,6 @@
 import io.quarkus.container.image.deployment.ContainerImageConfig;
 import io.quarkus.container.image.deployment.util.ImageUtil;
 import io.quarkus.container.spi.BaseImageInfoBuildItem;
-import io.quarkus.container.spi.ContainerImageCustomNameBuildItem;
 import io.quarkus.container.spi.ContainerImageInfoBuildItem;
 import io.quarkus.container.spi.ContainerImageLabelBuildItem;
 import io.quarkus.container.spi.FallbackContainerImageRegistryBuildItem;
@@ -102,12 +101,6 @@ public void checkOpenshift(ApplicationInfoBuildItem applicationInfo, Capabilitie
         }
     }
 
-    @BuildStep
-    public void populateCustomImageName(OpenshiftConfig openshiftConfig,
-            BuildProducer<ContainerImageCustomNameBuildItem> containerImageCustomName) {
-        openshiftConfig.name.ifPresent(name -> containerImageCustomName.produce(new ContainerImageCustomNameBuildItem(name)));
-    }
-
     @BuildStep
     public void populateInternalRegistry(OpenshiftConfig openshiftConfig, ContainerImageConfig containerImageConfig,
             Capabilities capabilities,

diff --git a/...rkus-standard-way/src/test/java/io/quarkus/it/kubernetes/OpenshiftWithCustomNameTest.java b/...rkus-standard-way/src/test/java/io/quarkus/it/kubernetes/OpenshiftWithCustomNameTest.java
@@ -72,14 +72,6 @@ public void assertGeneratedResources() throws IOException {
                         assertThat(t.getMetadata()).satisfies(metadata -> assertThat(metadata.getLabels()).containsAnyOf(
                                 entry("app.kubernetes.io/name", CUSTOM_NAME),
                                 entry("app.kubernetes.io/version", "0.1-SNAPSHOT")));
-
-                        assertThat(t.getSpec()).satisfies(podSpec -> {
-                            assertThat(podSpec.getContainers()).singleElement().satisfies(container -> {
-                                assertThat(container.getImage())
-                                        .isEqualTo(
-                                                "testme/" + CUSTOM_NAME + ":0.1-SNAPSHOT");
-                            });
-                        });
                     });
                 });
             });