Skip to content

Commit

Permalink
Fix test-coverage problem in ConfigInstantiator & add jacoco to depen…
Browse files Browse the repository at this point in the history
…dabot
  • Loading branch information
famod committed Feb 24, 2021
1 parent e2398cd commit 13af40c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ updates:
- dependency-name: org.mockito:*
- dependency-name: org.awaitility:awaitility
- dependency-name: com.thoughtworks.xstream:xstream
- dependency-name: org.jacoco:*
# Maven plugins
- dependency-name: net.revelc.code.formatter:formatter-maven-plugin
- dependency-name: net.revelc.code:impsort-maven-plugin
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,8 @@ then change into the `coverage-report` directory and run `mvn package`. The code
This currently does not work on Windows as it uses a shell script to copy all the classes and files into the code coverage
module.

If you just need a report for a single module, run `mvn install jacoco:report -Ptest-coverage` in that module (or with `-f ...`).

## Extensions

### Descriptions
Expand Down
3 changes: 2 additions & 1 deletion build-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@

<!-- Code Coverage Properties-->
<jacoco.agent.argLine></jacoco.agent.argLine>
<jacoco.version>0.8.5</jacoco.version>
<!-- Note: this version is also set in quarkus-bom but BOMs don't contribute to pluginManagement or properties -->
<jacoco.version>0.8.6</jacoco.version>

<maven-dependency-plugin.version>3.1.2</maven-dependency-plugin.version>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ private static void handleObject(String prefix, Object o, SmallRyeConfig config)
return;
}
for (Field field : cls.getDeclaredFields()) {
if (Modifier.isFinal(field.getModifiers())) {
if (field.isSynthetic() || Modifier.isFinal(field.getModifiers())) {
continue;
}
field.setAccessible(true);
Expand Down

0 comments on commit 13af40c

Please sign in to comment.