Merge pull request #39318 from geoand/#39289

Fail to deploy application when http and https ports are the same
quarkusio · Mar 11, 2024 · 04358cb · 04358cb
2 parents 68f1c90 + 21adee6
commit 04358cb
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/...ons/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java b/...ons/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/VertxHttpRecorder.java
@@ -1187,8 +1187,10 @@ public void handle(AsyncResult<HttpServer> event) {
 
                         if (https) {
                             actualHttpsPort = actualPort;
+                            validateHttpPorts(actualHttpPort, actualHttpsPort);
                         } else {
                             actualHttpPort = actualPort;
+                            validateHttpPorts(actualHttpPort, actualHttpsPort);
                         }
                         if (actualPort != options.getPort()) {
                             // Override quarkus.http(s)?.(test-)?port
@@ -1220,6 +1222,12 @@ public void handle(AsyncResult<HttpServer> event) {
 
                     }
                 }
+
+                private void validateHttpPorts(int httpPort, int httpsPort) {
+                    if (httpsPort == httpPort) {
+                        throw new IllegalArgumentException("Both http and https servers started on port " + httpPort);
+                    }
+                }
             });
         }