Hibernate Reactive + Vert.x Web routing + Mutiny quickstart #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
vert.x-web-mutiny
branch
2 times, most recently
from
884d360 to
b1d58f5
Compare
|
@DavideD could you rebase now that the other PR is in? Thanks! |
DavideD
force-pushed
the
vert.x-web-mutiny
branch
from
b1d58f5 to
85638d3
Compare
|
Done
…On Wed, Jul 15, 2020 at 10:21 AM Guillaume Smet ***@***.***> wrote:
@DavideD <https://github.com/DavideD> could you rebase now that the other
PR is in? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEIQ5PSK6HJGYZ3RQQRKZDR3VYKJANCNFSM4OZRYF7Q>
.
|
|
Actually, I left a dependency that's not needed. 1 sec |
|
It should be good to go but I don't think the PR build started after my last change |
|
We can wait and see if it picks it up |
|
Yeah GH is all borked right now. |
DavideD
force-pushed
the
vert.x-web-mutiny
branch
from
85638d3 to
084bc54
Compare
Sanne
approved these changes
Jul 20, 2020
|
Looks great ! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows #612
and I guess we shouldn't merge this until that one is also merged.
I'm sending the PR anyway because I don't want to loose the branch on my repository.