#2663 Misc. clean-up #226
Merged
#2663 Misc. clean-up #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Consistent default Kafka host * Removing superfluous dependency * Metadata exposed as JSON
|
It really starts to be late to do more adjustments. I have to run the full quickstart build with native before 2pm and it takes 2 hours to run... |
|
@gunnarmorling I merged quarkusio/quarkus#2880, can you make the adjustments you were talking about? |
|
Pushed one more commit for getting rid of the local Serde and using the one from the Kafka client module 🎉 |
|
I haven't run the full quickstart but I checked everything compiles, native included. @gunnarmorling I will merge this one but we will need to have these quickstarts included in the build. Right now, they are not as the modules are not declared in the parent pom. |
|
(I didn't do it myself as I thought you might have had a good reason to not do it) |
|
No good reason apart from not knowing about that aggregator POM :) So if
you have the bandwidth, feel free to add this (a parent for the two
probably would make sense).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cescoffier Some more clean-up for the KStreams quickstart. Once quarkusio/quarkus#2880 is merged, I'll send another one for removing the SerDe from the quickstart.