Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hibernate-search-orm-elasticsearch - reset Author_SEQ to start with 3 #1252

Conversation

rsvoboda
Copy link
Member

hibernate-search-orm-elasticsearch - reset Author_SEQ to start with 3

Import script inserts authors with id 1 and 2, the sequence should start with 3 then.

This got reveleaed with the latest changes in Quarkus main, I thinks it's quarkusio/quarkus#31947 done by @yrodiere, but didn't bisect Quarkus main to be sure.

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

It got me worried that my PR triggered this failure, so I investigated a bit. And it turns out the error was there all along, since a9ed414. It's just that because we were using the pooled optimizer (the default in ORM), ORM was using a pool from something like -47 to 2, starting with -47, so we wouldn't have seen the problem until we created more than 50 entities.

To be perfectly correct, a9ed414 should have reset the sequence to something like 53.
Now that we use the pooled-lo optimizer by default, though, resetting to 3 is the right choice.

@yrodiere
Copy link
Member

@Sanne See, I was telling you our current state was not nice and that people not familiar with optimizers would make mistakes. Turns out even people familiar with optimizers would make that mistake ;)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 22, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 63ef65d into quarkusio:development Mar 22, 2023
@rsvoboda rsvoboda deleted the restart.seq.hibernate-search-orm-elasticsearch branch December 12, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants