-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing config files (including latest configuration, as per http… #1120
Add missing config files (including latest configuration, as per http… #1120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PRs for quarkus-quickstarts repo need to target development
branch
Please adjust the target and keep just 60f6ace
(there are 4 commits in the PR)
60f6ace
to
4a006f1
Compare
I fixed the PR. |
I received this error when running
MBP 2019, macOS Monterey |
@radcortez, any thoughts? This is now well past my otel expertise :) |
open-telemetry/opentelemetry-collector#4063 changed the way this setting is specified (it is now under the tls section)
|
As @rsvoboda the |
Any updates on this? I just wanted to play around with that quickstart and was surprised by its sparseness. |
opentelemetry-quickstart/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
65355eb
to
3ffb20c
Compare
Thanks @famod, @rsvoboda, @radcortez. I lost track of this, but it's still needed as far as I can tell, so we should try and get it in. I've applied @famod's and @rsvoboda's suggestions, and rebased the PR. |
This comment has been minimized.
This comment has been minimized.
…s://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/opentelemetry.adoc) Add missing config files (including latest configuration, as per https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/opentelemetry.adoc)
Co-authored-by: Rostislav Svoboda <[email protected]>
3ffb20c
to
c23acd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls use vvv instead of the current quarkus.opentelemetry.*
entries, quarkus.opentelemetry.enabled=true
imo doesn't need replacemt, just drop.
quarkus.otel.exporter.otlp.traces.endpoint=http://localhost:4317
quarkus.otel.exporter.otlp.traces.headers=Authorization=Bearer my_secret
opentelemetry-quickstart/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Fixes #1114
I haven't changed any function, only added the three main config files referenced in https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/opentelemetry.adoc into the quickstart source code so the out-of-the-box experience is better.
I've manually confirmed these steps work with the new source (and no manual extra file creation):
and that http://localhost:16686/ then shows the traces.