Stork Quickstart #1028
Stork Quickstart #1028
Conversation
stork-quickstart/pom.xml
Outdated
| <dependency> | ||
| <groupId>io.smallrye.stork</groupId> | ||
| <artifactId>smallrye-stork-service-discovery-consul</artifactId> | ||
| <version>1.0.0.Beta1</version> |
There was a problem hiding this comment.
Again, maybe let's add these versions to the BOM?
There was a problem hiding this comment.
Waiting for Stork 1.0 to do so. It should not be long...
stork-quickstart/pom.xml
Outdated
| @@ -0,0 +1,140 @@ | |||
| <?xml version="1.0"?> | |||
| <project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0" | |||
There was a problem hiding this comment.
Could you reformat with 4 spaces? That's what we're trying to do with your POMs.
| quarkus.rest-client.extensions-api.shared=true | ||
| quarkus.rest-client.extensions-api.name=fojooh |
There was a problem hiding this comment.
sharing is an advanced feature IMO and I don't think this should be added to the quickstart
There was a problem hiding this comment.
Left-overs from another branch.
|
I think it would be good to add a command to start Consul somewhere. Maybe some script or docker-compose |
cescoffier
force-pushed
the
add-stork-quickstart
branch
from
d76665e to
3371bd8
Compare
|
All done (reformated the pom and remove the rest client shared attribute). |
Related to quarkusio/quarkus#22592
cescoffier
force-pushed
the
add-stork-quickstart
branch
from
3371bd8 to
af9e396
Compare
|
@michalszynkiewicz I let you do a final check and merge it if all is good. |
Related to quarkusio/quarkus#22592
Checklist:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.md