Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Camel Quarkus to 3.0.0-RC2 and Google Cloud Services to 2.2.0 #917

Closed
wants to merge 3 commits into from

Conversation

loicmathieu
Copy link
Contributor

@jamesnetherton this should fix the issue with Google Cloud services in Camel.

@gsmet please also backport it to 3.2.

@aloubyansky
Copy link
Member

@loicmathieu looks like the root pom.xml was not committed

@quarkus-bot

This comment has been minimized.

@loicmathieu
Copy link
Contributor Author

Sorry @aloubyansky, I added it to the commit.

@quarkus-bot

This comment has been minimized.

@aloubyansky
Copy link
Member

@loicmathieu how do these failures look to you?

@jamesnetherton
Copy link
Collaborator

I don't get why com.google.api:gax-* is being resolved as 2.19.1. We'd expect 2.31.1.

@aloubyansky
Copy link
Member

@jamesnetherton what would introduce 2.31.1?

@jamesnetherton
Copy link
Collaborator

jamesnetherton commented Aug 7, 2023

@jamesnetherton what would introduce 2.31.1?

This PR and the upgrade to the latest Google Cloud libs.

If you browse the dependency tree from quarkiverse/quarkus-google-cloud-services you see:

$ mvn dependency:tree -Dincludes="com.google.api:gax*"

[INFO] io.quarkiverse.googlecloudservices:quarkus-google-cloud-services-main-it:jar:1.3.0-SNAPSHOT
[INFO] \- io.quarkiverse.googlecloudservices:quarkus-google-cloud-storage:jar:1.3.0-SNAPSHOT:compile
[INFO]    \- com.google.cloud:google-cloud-storage:jar:2.25.0:compile
[INFO]       +- com.google.api:gax-httpjson:jar:2.31.1:compile
[INFO]       +- com.google.api:gax:jar:2.31.1:compile
[INFO]       \- com.google.api:gax-grpc:jar:2.31.1:compile

But in the platform we see:

$ mvn dependency:tree -Dincludes="com.google.api:gax*"

[INFO] io.quarkus.platform:quarkus-google-cloud-services-main-it:jar:999-SNAPSHOT
[INFO] \- io.quarkiverse.googlecloudservices:quarkus-google-cloud-services-main-it:jar:2.2.0:compile
[INFO]    \- io.quarkiverse.googlecloudservices:quarkus-google-cloud-storage:jar:2.2.0:compile
[INFO]       \- com.google.cloud:google-cloud-storage:jar:2.25.0:compile
[INFO]          +- com.google.api:gax-httpjson:jar:2.31.1:compile
[INFO]          +- com.google.api:gax:jar:2.19.1:compile
[INFO]          \- com.google.api:gax-grpc:jar:2.19.1:compile

@aloubyansky
Copy link
Member

It's due to the quarkus-bom including

<dependency>
    <groupId>com.google.api.grpc</groupId>
    <artifactId>proto-google-common-protos</artifactId>
    <version>2.19.1</version>
</dependency>

from https://github.com/googleapis/sdk-platform-java resulting in
Screenshot from 2023-08-07 14-35-06

@loicmathieu
Copy link
Contributor Author

@jamesnetherton it's not the first time we have an issue due to this library that is not updated at Quarkus side. I have no idea how we can work around that.

@aloubyansky
Copy link
Member

@gsmet we should bump the version of proto-google-common-protos in quarkus-bom. We could do it in the platform BOM but to test it properly we should do it in the core repo.

@aloubyansky
Copy link
Member

I opened quarkusio/quarkus#35239

@aloubyansky
Copy link
Member

In the meantime, we could apply the following to the platform

diff --git a/pom.xml b/pom.xml
index 995d60b61..5f6f920ec 100644
--- a/pom.xml
+++ b/pom.xml
@@ -188,6 +188,8 @@
                                     <dependency>io.quarkiverse.vault:quarkus-vault:${quarkus-vault.version}</dependency>
                                     <dependency>io.quarkiverse.vault:quarkus-vault-deployment:${quarkus-vault.version}</dependency>
                                     <dependency>io.quarkiverse.vault:quarkus-vault-model:${quarkus-vault.version}</dependency>
+                                    <!-- temporary enforce 2.31.1 until https://github.com/quarkusio/quarkus/pull/35239 makes its way in -->
+                                    <dependency>com.google.api.grpc:proto-google-common-protos:2.31.1</dependency>

@aloubyansky
Copy link
Member

Oh, it actually doesn't exist in that version

@aloubyansky
Copy link
Member

So they use the same repo but release submodules under different versions. I'll have a look a bit later how to handle this better.

@loicmathieu
Copy link
Contributor Author

I opened quarkusio/quarkus#35283 to upgrade the lib at Quarkus side.

@gsmet gsmet changed the title Upgrade to Google Cloud Services 2.2.0 Upgrade Camel Quarkus to 3.0.0-RC2 and Google Cloud Services to 2.2.0 Aug 10, 2023
@gsmet
Copy link
Member

gsmet commented Aug 10, 2023

I made some adjustments and also included the Camel Quarkus update here to check we can come up with something working with both updated.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Aug 10, 2023

⚠️ Unable to include the stracktraces as the report was too long. See annotations below for the details.

Failing Jobs - Building b3280e3

Status Name Step Failures Logs Raw logs
Build - JDK 17 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 17 #

- Failing:  

📦 Root project

Failed to execute goal io.quarkus:quarkus-platform-bom-maven-plugin:0.0.91:invoke-platform-project (build-platform-project) on project quarkus-platform-config: Failed to build the platform project, please consult the errors logged above.

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-cxf-soap-grouped

org.apache.camel.quarkus.component.cxf.soap.converter.it.CxfSoapConverterTest.convertTest(String)[1] line 37 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.converter.it.CxfSoapConverterTest.convertTest(String)[2] line 37 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.converter.it.CxfSoapConverterTest.convertTest(String)[3] line 37 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.cxf.way.CxfWsTrustCxfWayTest.stsWsdl line 58 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.cxf.way.CxfWsTrustCxfWayTest.wsdl line 74 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.cxf.way.CxfWsTrustCxfWayTest.programmaticSts line 102 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.CxfWsTrustTest.stsWsdl line 58 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.CxfWsTrustTest.programmaticStsNotSet line 116 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.CxfWsTrustTest.wsdl line 74 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.it.ws.trust.CxfWsTrustTest.programmaticSts line 98 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.awt.it.CxfSoapMtomAwtTest.uploadDownloadMtom(boolean)[1] line 47 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.awt.it.CxfSoapMtomAwtTest.uploadDownloadMtom(boolean)[2] line 47 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.it.CxfSoapMtomTest.uploadDownloadMtom(boolean, String)[1] line 60 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.it.CxfSoapMtomTest.uploadDownloadMtom(boolean, String)[2] line 60 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.it.CxfSoapMtomTest.uploadDownloadMtom(boolean, String)[3] line 60 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.mtom.it.CxfSoapMtomTest.uploadDownloadMtom(boolean, String)[4] line 60 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.cxf.way.it.CxfWssSecurityPolicyServerCxfWayTest.wsdl line 198 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.cxf.way.it.CxfWssSecurityPolicyServerCxfWayTest.encrypetdSigned line 42 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.cxf.way.it.CxfWssSecurityPolicyServerCxfWayTest.fakeSigned line 181 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.cxf.way.it.CxfWssSecurityPolicyServerCxfWayTest.noSecurityConfig line 58 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.cxf.way.it.CxfWssSecurityPolicyServerCxfWayTest.unencryptedUnsigned line 79 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.it.CxfWssSecurityPolicyServerTest.wsdl line 197 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.it.CxfWssSecurityPolicyServerTest.encrypetdSigned line 41 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.it.CxfWssSecurityPolicyServerTest.fakeSigned line 180 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.it.CxfWssSecurityPolicyServerTest.noSecurityConfig line 57 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.securitypolicy.server.it.CxfWssSecurityPolicyServerTest.unencryptedUnsigned line 78 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.echoServiceResponseFromRoute line 100 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.codeFirstWsdl line 67 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.codeFirstSoapService line 82 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.echoServiceResponseFromImpl line 108 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.testCodeFirstSoapServiceDataFormats(String)[1] line 91 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.testCodeFirstSoapServiceDataFormats(String)[2] line 91 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.simpleSoapService(String)[1] line 48 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.CxfSoapServiceTest.simpleSoapService(String)[2] line 48 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.server.it.Java2wsTest.java2WsCodeFirstService line 59 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.ssl.it.CxfSoapGlobalTrustedSslTest.testInvokingTrustedRoute line 39 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.ssl.it.CxfSoapSslTest.testInvokingTrustedRoute line 40 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.wss.server.it.CxfSoapWssServerTest.anonymous line 120 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.wss.server.it.CxfSoapWssServerTest.usernameTokenCorrectPassword line 72 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.wss.server.it.CxfSoapWssServerTest.wsdl line 56 - More details - Source on GitHub

org.apache.camel.quarkus.component.cxf.soap.wss.server.it.CxfSoapWssServerTest.usernameTokenBadPassword line 83 - More details - Source on GitHub

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-ftp

org.apache.camel.quarkus.component.sftp.it.SftpTest.testSftpComponent line 39 - More details - Source on GitHub

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-google-pubsub

org.apache.camel.quarkus.component.google.pubsub.it.GooglePubsubTest.testAck - More details - Source on GitHub

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-platform-http

org.apache.camel.quarkus.component.http.server.it.PlatformHttpTest. - More details - Source on GitHub

📦 generated-platform-project/quarkus-camel/integration-tests/camel-quarkus-integration-test-ssh

org.apache.camel.quarkus.component.ssh.it.SshTest.testWriteToSSHAndReadFromSSH line 40 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-metrics

io.quarkiverse.cxf.metrics.it.MetricsTest.serverAndClient line 45 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-mtom

io.quarkiverse.cxf.it.ws.mtom.server.MtomTest.dataHandler line 33 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-mtom-awt

io.quarkiverse.cxf.it.ws.mtom.awt.server.MtomAwtTest.uploadDownloadMtomWithWrappers line 23 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.mtom.awt.server.MtomAwtTest.uploadDownloadMtom line 28 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-server

io.quarkiverse.cxf.it.server.ClientGreetingTest.testWsReply line 64 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.ClientGreetingTest.testWsdlAvailable line 59 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.FaultyHelloServiceTest.hello line 14 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.FruitServiceTest.crud line 19 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.GreetingSOAPHandlerTest.soapHandler line 34 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.GreetingWebServiceImplTest. line 15 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.GreetingWebServiceNoIntfTest. line 17 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.HelloServiceTest.hello line 14 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.Java2wsTest.java2WsFaultyHelloService line 44 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.Java2wsTest.java2WsHelloService line 38 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.ProviderServiceTest.testSourceMessageProvider line 77 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.ProviderServiceTest.testStreamSourcePayloadProvider line 105 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.ProviderServiceTest.testSourcePayloadProvider line 91 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.ProviderServiceTest.testSOAPMessageProvider line 63 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedHostHeader line 71 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedHeaders line 104 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedPortHeader line 86 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedPrefixHeader line 41 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedProtoHeader line 56 - More details - Source on GitHub

io.quarkiverse.cxf.it.server.XForwardedHeadersTest.testXForwardedHeadersParrallel line 138 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-ws-addressing

io.quarkiverse.cxf.it.ws.addressing.server.WsAddressingAnonymousTest.wsdl line 35 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.addressing.server.WsAddressingAnonymousTest.rawAddressing line 81 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.addressing.server.WsAddressingAnonymousTest.rawSoap line 54 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.addressing.server.WsAddressingDecoupledTest.wsdl line 41 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.addressing.server.WsAddressingDecoupledTest.decoupled line 54 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-ws-rm

io.quarkiverse.cxf.it.ws.rm.server.WsReliableMessagingTest.getSourceSequencesSize line 28 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-ws-security-server

io.quarkiverse.cxf.it.ws.securitypolicy.server.CxfWssSecurityPolicyServerTest.wsdl line 183 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.securitypolicy.server.CxfWssSecurityPolicyServerTest.encrypetdSigned line 27 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.securitypolicy.server.CxfWssSecurityPolicyServerTest.fakeSigned line 166 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.securitypolicy.server.CxfWssSecurityPolicyServerTest.noSecurityConfig line 43 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.securitypolicy.server.CxfWssSecurityPolicyServerTest.unencryptedUnsigned line 64 - More details - Source on GitHub

io.quarkiverse.cxf.it.wss.server.CxfWssServerTest.anonymous line 31 - More details - Source on GitHub

io.quarkiverse.cxf.it.wss.server.CxfWssServerTest.usernameToken line 47 - More details - Source on GitHub

📦 generated-platform-project/quarkus-cxf/integration-tests/quarkus-cxf-integration-test-ws-trust

io.quarkiverse.cxf.it.ws.trust.CxfWsTrustTest.stsWsdl line 43 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.trust.CxfWsTrustTest.wsdl line 59 - More details - Source on GitHub

io.quarkiverse.cxf.it.ws.trust.CxfWsTrustTest.programmaticSts line 87 - More details - Source on GitHub

📦 generated-platform-project/quarkus-google-cloud-services/integration-tests/quarkus-google-cloud-services-main-it

io.quarkiverse.googlecloudservices.it.BigtableResourceTest. - More details - Source on GitHub

io.quarkiverse.googlecloudservices.it.SpannerResourceTest. - More details - Source on GitHub

io.quarkiverse.googlecloudservices.it.StorageResourceTest. - More details - Source on GitHub

@gsmet
Copy link
Member

gsmet commented Aug 10, 2023

OK, it doesn't look worse. I will try to backport it to 3.2 where we have a cleaner status.

@loicmathieu
Copy link
Contributor Author

@gsmet we really need to have quarkusio/quarkus#35283 merged first, that would make this PR to be green I think.

@aloubyansky
Copy link
Member

@loicmathieu AFAICS, it'd be equivalent to what @gsmet added to this PR.

@jamesnetherton
Copy link
Collaborator

Can we try adding overrides for the gax misalignment? E.g:

<dependency>com.google.api:gax:2.31.1</dependency>
<dependency>com.google.api:gax:2.31.1:testlib</dependency>
<dependency>com.google.api:gax-grpc:2.31.1</dependency>
<dependency>com.google.api:gax-grpc:2.31.1:testlib</dependency>

@loicmathieu
Copy link
Contributor Author

This PR cannot work as it can only be merged on Quarkus 3.2 now that the removal of bootstrap config is merged.

@gsmet gsmet closed this Aug 17, 2023
@loicmathieu loicmathieu deleted the gcp-2-2-0 branch August 24, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants