Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final #397

radtriste · 2021-12-08T14:46:55Z

No description provided.

radtriste · 2021-12-09T07:56:51Z

@evacchi any idea here ?

EDIT: Note that this is targeting platform 2.5 as I know that it would fail on 2.6 ...

evacchi · 2021-12-09T09:35:13Z

failure seems related to @ia3andy's issue with the codestart /cc FYI @tarilabs

tarilabs · 2021-12-09T09:52:55Z

meaning is there an upstream quarkus issue to track please?

aloubyansky · 2021-12-09T14:21:07Z

You may need to propagate the maven.settings in the platform test too.

aloubyansky · 2021-12-09T14:21:25Z

It was fixed in 2.5.1.Final quarkusio/quarkus#21673

aloubyansky · 2021-12-09T14:30:05Z

Let's try with this change

[aloubyansky@localhost quarkus-platform]$ git diff pom.xml
diff --git a/pom.xml b/pom.xml
index 3e097561..bfee8065 100644
--- a/pom.xml
+++ b/pom.xml
@@ -282,6 +282,12 @@
                                         <container.image.infinispan>infinispan/server:12.1.4.Final</container.image.infinispan>
                                         <container.image.kafka>confluentinc/cp-kafka:5.4.3</container.image.kafka>
                                         <container.image.keycloak>jboss/keycloak:14.0.0</container.image.keycloak>
+                                        <!-- some dev tools tests need the following properties -->
+                                        <maven.home>${maven.home}</maven.home>
+                                        <maven.repo.local>${settings.localRepository}</maven.repo.local>
+                                        <maven.settings>${session.request.userSettingsFile.path}</maven.settings>
+                                        <project.version>${project.version}</project.version>
+                                        <project.groupId>${project.groupId}</project.groupId>
                                     </systemProperties>
                                 </defaultTestConfig>
                                 <testCatalogArtifact>org.kie.kogito:kogito-quarkus-test-list::xml:${kogito-quarkus.version}</testCatalogArtifact>

aloubyansky · 2021-12-09T15:09:41Z

@radtriste could you apply the change?

aloubyansky · 2021-12-09T15:27:33Z

Didn't help it seems. I'll check what's going on.

aloubyansky · 2021-12-09T16:06:11Z

Ok, here is what happens. The test generates a new project and executes a Maven command to verify it can be built. The staging repository that was added to the platform POM isn't available for the created project. With the maven.settings property we are passing the Maven settings file to the test but the Maven settings doesn't include the staging repo neither.

So, the way to make it work will be to add the staging repo not to the platform's POM file but to the .github/mvn-settings.xml. Could you do that @radtriste?

radtriste · 2021-12-09T16:27:56Z

did it. but FYI, Kogito artifacts have been released already, so this should not be needed anymore. But good to know for the next time ;)

aloubyansky · 2021-12-09T16:35:21Z

If they are on Central already then the change will be useless.

gsmet · 2021-12-09T17:21:07Z

I'm releasing Quarkus 2.5.2.Final tomorrow morning early Paris time so if you want this in, we need the staging repo gone and the PR rebased and regenerated with ./mvw -Dsync. I'm not sure there will be a 2.5.3.Final.

gsmet · 2021-12-09T17:22:41Z

Given the late time, I will do it and see how it goes.

gsmet · 2021-12-09T17:25:28Z

The artifacts are not available yet unfortunately.

gsmet · 2021-12-09T17:28:30Z

Platform release will probably be around 2pm so I'll check tomorrow morning. I think it's going to be a pain to rebase so I will rebase it this evening.

gsmet · 2021-12-09T17:29:40Z

It will conflict with #402 so I will rebase it once the other PR is merged.

gsmet · 2021-12-09T19:08:34Z

I just force pushed a rebase on top of latest 2.5.

aloubyansky · 2021-12-09T19:42:01Z

BTW, it'd be better to use $$ for the properties instead of $ to avoid revealing actual paths on your local machines. E.g.

<maven.settings>$${session.request.userSettingsFile.path}</maven.settings>

instead of

<maven.settings>${session.request.userSettingsFile.path}</maven.settings>

aloubyansky · 2021-12-10T05:46:21Z

The artifacts still aren't in Central. But I could make progress with these changes:

diff --git a/.github/mvn-settings.xml b/.github/mvn-settings.xml
index d5e4664b..66ae9b04 100644
--- a/.github/mvn-settings.xml
+++ b/.github/mvn-settings.xml
@@ -14,6 +14,14 @@
             <enabled>false</enabled>
           </snapshots>
         </repository>
+        <repository>
+            <snapshots>
+                <enabled>false</enabled>
+            </snapshots>
+            <id>kogito</id>
+            <name>kogito</name>
+            <url>https://repository.jboss.org/nexus/content/groups/kogito-public/</url>
+        </repository>

diff --git a/pom.xml b/pom.xml
index 401525a5..f6a46b24 100644
--- a/pom.xml
+++ b/pom.xml
@@ -66,8 +66,8 @@
         <quarkus-blaze-persistence.version>1.6.3</quarkus-blaze-persistence.version>
         <quarkus-cassandra-client.version>1.1.1</quarkus-cassandra-client.version>
 
-        <kogito-quarkus.version>1.14.0.Final</kogito-quarkus.version>
-        <optaplanner-quarkus.version>8.14.0.Final</optaplanner-quarkus.version>
+        <kogito-quarkus.version>1.14.1.Final</kogito-quarkus.version>
+        <optaplanner-quarkus.version>8.14.1.Final</optaplanner-quarkus.version>
 
         <quarkus-google-cloud-services.version>0.11.0</quarkus-google-cloud-services.version>
 
@@ -238,6 +238,14 @@
                                         <container.image.infinispan>infinispan/server:12.1.4.Final</container.image.infinispan>
                                         <container.image.kafka>confluentinc/cp-kafka:5.4.3</container.image.kafka>
                                         <container.image.keycloak>jboss/keycloak:14.0.0</container.image.keycloak>
+
+                                        <!-- some dev tools tests need the following properties -->
+                                        <maven.home>${maven.home}</maven.home>
+                                        <maven.repo.local>$${settings.localRepository}</maven.repo.local>
+                                        <maven.settings>$${session.request.userSettingsFile.path}</maven.settings>
+                                        <project.version>${project.version}</project.version>
+                                        <project.groupId>${project.groupId}</project.groupId>

However, I still got one failure

[ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 18.261 s <<< FAILURE! - in org.kie.kogito.quarkus.dmn.KogitoDMNCodeCodestartIT
[ERROR] testContent  Time elapsed: 0.061 s  <<< FAILURE!
java.lang.AssertionError: 
[corresponding snapshot file not found for KogitoDMNCodeCodestartIT/testContent/src_test_java_ilove_quark_us_PricingTest.java (Use -Dsnap to create it automatically)] 
Expecting path:
  src/test/resources/__snapshots__/KogitoDMNCodeCodestartIT/testContent/src_test_java_ilove_quark_us_PricingTest.java
to exist (symbolic links were followed).
	at org.kie.kogito.quarkus.dmn.KogitoDMNCodeCodestartIT.testContent(KogitoDMNCodeCodestartIT.java:53)

Which means the necessary snapshot files will need to be copied to the resources.

aloubyansky · 2021-12-10T06:18:29Z

A couple of options to improve the setup in perspective:

enhance the generator to extract the resources from the test jar
make the code start tests look for resources on the classpath

radtriste · 2021-12-10T06:43:21Z

trying with https://repository.jboss.org/nexus/content/groups/public/ which is were you can find current 1.14.1 artifacts

radtriste · 2021-12-10T06:45:53Z

The artifacts are not available yet unfortunately.

Artifacts are on Jboss Nexus but seems they were not sync on Central. Asking Jboss nexus team about that

radtriste · 2021-12-10T07:01:07Z

ctual paths on your local machines. E

This does not work for maven.home ?

aloubyansky · 2021-12-10T08:22:45Z

Yes, it's kind of weird. Perhaps, omit maven.home for now.

aloubyansky · 2021-12-10T08:25:26Z

Unless you copy the snapshots similar to https://github.com/quarkusio/quarkus-platform/blob/main/pom.xml#L214-L217 it won't work right now. If you don't want to do that, you can simply skip the test for now.

gsmet · 2021-12-10T09:27:10Z

@evacchi @radtriste could you consider moving to s01.oss.sonatype.org to deploy your releases? It's just impossible to do any sort of release planning with repository.jboss.org.

radtriste · 2021-12-10T09:31:28Z

@gsmet I do get it but for now all projects in bsig are deployed through JBoss Nexus.

We do have an issue though: https://issues.redhat.com/browse/BXMSPROD-1513
You may comment there to push a bit forward.

Technically I don't think there is a big difference as sonatype is a Nexus behind so most commands should work there but it is true that this is an external repository and we would depend on it ...

gsmet · 2021-12-10T09:59:56Z

@radtriste I can understand that but from my experience repository.jboss.org sync is too unreliable to plan anything. I think it's too late to have 1.14.1 into 2.5.2 now.

But we really need a new release for 2.6 so we'd better get it sync on time... /cc @evacchi

evacchi · 2021-12-10T11:10:59Z

@radtriste the timeline for Quarkus 2.6 is

Core Final on December 15th
Full Platform release (and official announcement) on December 22nd

which means that we have between 15 and 22 to release 1.14.2. As far as I know the fix by @manstis can be easily backported and it is backwards-compatible to 2.5, so we can even start a release immediately after merging that (building against Quarkus 2.5) Is that correct @gsmet ?

gsmet · 2021-12-10T13:16:54Z

@evacchi yes, that's my understanding too. Just be careful, I release on 22nd so you have until 21st.

You can build with 2.5 and you can already test with 2.6.0.CR1 (platform main was already updated).

gsmet · 2021-12-10T13:17:26Z

OK, still nothing on Central. Officially too late.

gsmet · 2021-12-17T22:10:16Z

The artifacts are on Central now.

gsmet · 2021-12-20T14:18:08Z

Per discussion with the Kogito team, we will merge the next release instead.

radtriste changed the base branch from main to 2.5 December 8, 2021 16:01

radtriste added 3 commits December 9, 2021 20:08

Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final

6ce1f8e

apply change suggested

9da61c6

added staging repo to maven settings

2f303fc

updated repository

407d548

disable failing tests

51e2ff6

removed staging repo

75412a3

radtriste marked this pull request as ready for review December 20, 2021 13:26

gsmet closed this Dec 20, 2021

radtriste deleted the bump-kogito-1.14.1.Final+optaplanner-8.14.1.Final branch December 20, 2021 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final #397

Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final #397

radtriste commented Dec 8, 2021

radtriste commented Dec 9, 2021 •

edited

Loading

evacchi commented Dec 9, 2021

tarilabs commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

radtriste commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

radtriste commented Dec 10, 2021

radtriste commented Dec 10, 2021

radtriste commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

gsmet commented Dec 10, 2021

radtriste commented Dec 10, 2021

gsmet commented Dec 10, 2021

evacchi commented Dec 10, 2021

gsmet commented Dec 10, 2021

gsmet commented Dec 10, 2021

gsmet commented Dec 17, 2021

gsmet commented Dec 20, 2021

Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final #397

Kogito 1.14.1.Final + OptaPlanner 8.14.1.Final #397

Conversation

radtriste commented Dec 8, 2021

radtriste commented Dec 9, 2021 • edited Loading

evacchi commented Dec 9, 2021

tarilabs commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

radtriste commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

gsmet commented Dec 9, 2021

aloubyansky commented Dec 9, 2021

aloubyansky commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

radtriste commented Dec 10, 2021

radtriste commented Dec 10, 2021

radtriste commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

aloubyansky commented Dec 10, 2021

gsmet commented Dec 10, 2021

radtriste commented Dec 10, 2021

gsmet commented Dec 10, 2021

evacchi commented Dec 10, 2021

gsmet commented Dec 10, 2021

gsmet commented Dec 10, 2021

gsmet commented Dec 17, 2021

gsmet commented Dec 20, 2021

radtriste commented Dec 9, 2021 •

edited

Loading