Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Camel Quarkus 3.11.0 #1213

Merged
merged 1 commit into from
May 28, 2024
Merged

Upgrade to Camel Quarkus 3.11.0 #1213

merged 1 commit into from
May 28, 2024

Conversation

zbendhiba
Copy link
Collaborator

Make sure that you have run ./mvnw -Dsync and included the changes in your pull request (preferably in the same commit, unless it makes sense to do otherwise).

Thanks!

Copy link

quarkus-bot bot commented May 27, 2024

Status for workflow CI Build

This is the status report for running CI Build on commit c24100d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@zbendhiba
Copy link
Collaborator Author

Hello @aloubyansky @gsmet
I noticed that the ./mvnw -Dsyncmoved many ${camel-quarkus.version}to 3.11.0. I'm not sure if that is expected or not ?

@aloubyansky
Copy link
Member

It's ok, it's a coincidence of having Quarkus core version matching Camel Quarkus version and the generator could not decide which property to use.

@gsmet
Copy link
Member

gsmet commented May 28, 2024

I noticed that the ./mvnw -Dsyncmoved many ${camel-quarkus.version}to 3.11.0. I'm not sure if that is expected or not ?

Yeah it is a bit annoying as it generates a lot of noise in the PR but basically Maven randomly (probably not randomly but you get the point) chooses a property that match the version. So when updating a given version, and you have a property that matches, it will pick one and it might not be the previous one.

@gsmet gsmet merged commit 1606272 into quarkusio:main May 28, 2024
3 checks passed
@zbendhiba
Copy link
Collaborator Author

Thanks for the explanations @gsmet @aloubyansky

@zbendhiba zbendhiba deleted the cq-3.11.0 branch May 28, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants