Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vault 3.5.0 #1130

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Vault 3.5.0 #1130

merged 1 commit into from
Feb 27, 2024

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Feb 26, 2024

https://github.com/quarkiverse/quarkus-vault/releases/tag/3.5.0 - Quarkus 3.8, JDK 17 + bug fix
note that the synch operation modified also assertj version to 3.25.3 (like in vault), which I did not include in this PR

@vsevel
Copy link
Contributor Author

vsevel commented Feb 26, 2024

this build failed complaining about the synch.
should I run again, and include the assertj version change?

This comment has been minimized.

@vsevel
Copy link
Contributor Author

vsevel commented Feb 26, 2024

if I ru the sync, it adds:

     <dependency>
       <groupId>org.assertj</groupId>
       <artifactId>assertj-core</artifactId>
-      <version>3.24.2</version>
+      <version>3.25.3</version>
       <scope>test</scope>
     </dependency>

what should I do @gsmet ?

@aloubyansky
Copy link
Member

@vsevel all the changes are supposed to be added to the commit, otherwise it will fail the check. Then it'll be up to us to review the changes before merging.
If you have concerns about some of them, please add them all and add your comments for us to review. Thanks.

@vsevel vsevel force-pushed the feature/vault_3.5.0 branch from 1316869 to 33207b7 Compare February 26, 2024 20:11
@aloubyansky
Copy link
Member

It looks like that version bump in the test module comes from quarkus-vault project itself. So far looks good to me.

@vsevel
Copy link
Contributor Author

vsevel commented Feb 26, 2024

It seemed strange to me that a bump in a test module of an ext would lead to a version change in the plateform ...

Copy link

quarkus-bot bot commented Feb 26, 2024

Status for workflow CI Build

This is the status report for running CI Build on commit 33207b7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@aloubyansky
Copy link
Member

It's a bump in the corresponding test module in the platform though. So it is consistent with the original test dependencies.

@gsmet gsmet merged commit 3fa71db into quarkusio:main Feb 27, 2024
3 checks passed
@gsmet
Copy link
Member

gsmet commented Feb 27, 2024

Thanks!

@vsevel vsevel deleted the feature/vault_3.5.0 branch February 27, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants