-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vault 3.5.0 #1130
Vault 3.5.0 #1130
Conversation
this build failed complaining about the synch. |
This comment has been minimized.
This comment has been minimized.
if I ru the sync, it adds:
what should I do @gsmet ? |
@vsevel all the changes are supposed to be added to the commit, otherwise it will fail the check. Then it'll be up to us to review the changes before merging. |
1316869
to
33207b7
Compare
It looks like that version bump in the test module comes from quarkus-vault project itself. So far looks good to me. |
It seemed strange to me that a bump in a test module of an ext would lead to a version change in the plateform ... |
Status for workflow
|
It's a bump in the corresponding test module in the platform though. So it is consistent with the original test dependencies. |
Thanks! |
https://github.com/quarkiverse/quarkus-vault/releases/tag/3.5.0 - Quarkus 3.8, JDK 17 + bug fix
note that the synch operation modified also assertj version to
3.25.3
(like in vault), which I did not include in this PR