Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the Mandrel and S2i builds to avoid disk space issues #253

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

cescoffier
Copy link
Member

No description provided.

Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cescoffier, I didn't find the time to do the cleanup myself.

Please see my comments about the Mandrel images.

quarkus-mandrel-builder-image/mandrel-22.x.yaml Outdated Show resolved Hide resolved
quarkus-mandrel-builder-image/mandrel.yaml Show resolved Hide resolved
quarkus-mandrel-builder-image/mandrel.yaml Show resolved Hide resolved
Copy link
Collaborator

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can also drop the jdk-20 image

Comment on lines +12 to +19
- graalvm-version: 23.0.1.2-Final
java-version: 20
tags: 23.0-java20, 23.0-jdk-20, jdk-20, jdk-20.0.2
variants:
- sha: be992959df83beb9f5fe0ffe4606d76b2deba6cb86322b9d3614f09a8a2fbbc8
arch: amd64
- sha: e6ed1f76292a5f44bff076225ebbb503b940180b14d6468d8722769ff7eb9e9e
arch: arm64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we drop this as well. JDK 21 is now out and 23.0 based on JDK 20 is no longer supported (i.e. it doesn't receive any updates)

Suggested change
- graalvm-version: 23.0.1.2-Final
java-version: 20
tags: 23.0-java20, 23.0-jdk-20, jdk-20, jdk-20.0.2
variants:
- sha: be992959df83beb9f5fe0ffe4606d76b2deba6cb86322b9d3614f09a8a2fbbc8
arch: amd64
- sha: e6ed1f76292a5f44bff076225ebbb503b940180b14d6468d8722769ff7eb9e9e
arch: arm64

@cescoffier cescoffier merged commit da77a7c into quarkusio:main Oct 17, 2023
8 checks passed
@cescoffier cescoffier deleted the split-build branch October 17, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants