Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build distroless image using cekit in ci #118

Merged
merged 1 commit into from
Jan 13, 2021
Merged

build distroless image using cekit in ci #118

merged 1 commit into from
Jan 13, 2021

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Jan 12, 2021

matthyx
matthyx commented Jan 12, 2021
View reviewed changes
quarkus-distroless-image.yaml
version: stable-slim
from: debian:stable-slim

# need to rename from image into "scratch" to disable /tmp cleanup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see here https://github.com/cekit/cekit/blob/master/cekit/templates/template.jinja#L208

@matthyx
Copy link
Contributor Author

matthyx commented Jan 12, 2021

  • libssl comes from gcr.io/distroless/base
  • gcr.io/distroless/cc brings libc++
  • I have to add libz from debian-slim

@matthyx matthyx force-pushed the distroless branch 3 times, most recently from 01a26d9 to ad207ba Compare January 12, 2021 14:00
@matthyx
Copy link
Contributor Author

matthyx commented Jan 12, 2021

This cekit config replicates what's described here, but with a distroless/cc base image as we need libc++:
GoogleContainerTools/distroless#217 (comment)

@maxday maxday mentioned this pull request Jan 12, 2021
Closed
@matthyx
Copy link
Contributor Author

matthyx commented Jan 13, 2021

@cescoffier is there a way to rerun tests... I think these failures are unrelated to my changes

@cescoffier
Copy link
Member

Thanks a lot!

@cescoffier cescoffier merged commit f1b093d into quarkusio:master Jan 13, 2021
@matthyx matthyx deleted the distroless branch January 13, 2021 09:10
@maxday maxday mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthyx @cescoffier