Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize title when pushing to version branches #437

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

jmartisk
Copy link
Contributor

@jmartisk jmartisk commented Apr 8, 2024

Fixes #401

@gsmet
Copy link
Member

gsmet commented Apr 8, 2024

I started working on something that would add the prefix automatically if not present.

I didn’t finish it. I’ll see if I can revive it.

But in the meantime, we can probably merge and deploy this.

@gsmet gsmet changed the title Accept [x.y] and (x.y) PR title prefixes Normalize title when pushing to version branches Apr 10, 2024
@gsmet
Copy link
Member

gsmet commented Apr 10, 2024

@jmartisk I pushed an additional commit that goes a little further and try to normalize titles to include the branch for version branches. This will avoid us missing the information and merging to back branches without noticing it (which happened a few times).

@gsmet gsmet merged commit 2fc6454 into quarkusio:main Apr 10, 2024
1 check passed
@gsmet
Copy link
Member

gsmet commented Apr 10, 2024

BTW, thanks for creating the PR, I wouldn't have made it a priority if you didn't and it was definitely annoying :).

@jmartisk jmartisk deleted the issue-401 branch April 11, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept [X.Y] prefix for pull request when checking editorial rules
2 participants