Add Quarkus Playwright #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Funny that this extension never made it to the extension catalog. Maybe exclude the previous versions? |
|
Its because its a "test" only depdenency so it has no runtime and thus no |
|
OK 2.0.0 is in Maven Central now! |
gastaldi
reviewed
Oct 28, 2024
|
OK see if I did that correctly? |
|
That would work I think, but I thought it would be nice if using the same patterm as above 😅 |
gastaldi
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft until this PR is merged: quarkiverse/quarkus-playwright#95
That switches it from a Test resource to a Runtime resource