Remove container nesting to avoid hyper-stretched cards #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 The PR is closed and the preview is expired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #958.
This seems to happen when the number of cards drops below a certain number, which is why the search triggers it. Filtering for the ‘core’ category also shows the problem.
I tried setting the max-height on the cards, but that didn’t help, because the grid was laid out the same, and the extra space was in the gutters. What seemed to solve the problem was undoing some nesting of containers, so I’ve done that. With that, I was able to very occasionally get huge cards, but only in the case where everything fit into one row. I’ve left in the max-height as a failsafe for that case.