Be a bit smarter in how we wait for the github rate limit to refresh #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of blindly retrying
holly-cummins
force-pushed
the
rate-limit-wait
branch
from
5d9ccd9 to
84dbd2b
Compare
|
Bah, typical. After days of long builds and rate limiting failures, this one went through cleanly in about three minutes with no rate limiting, but not because of the changes I'd made. |
|
🙈 The PR is closed and the preview is expired. |
|
I built again, when I could see the rate limiter was being hit, and the build was slower, but I did not get my logging that I expected. I'm going to merge, and I'll keep an eye on it. |
This was referenced Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our strategy of blindly retrying with a long backoff isn't really working for us.
Confusingly, I couldn't fully test this locally, because despite building three times with an empty cache, I never hit the rate limiter.