Fix cache #402
Merged
Fix cache #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ur the ts parameter
|
🙈 The PR is closed and the preview is expired. |
|
In order words, any time the cache got ingested, the expiries got renewed- with regular builds, it was an infinite lifetime cache! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect updates to GitHub data to take a few days, but it's been about a week and I'm still seeing stale data. On investigation, I discovered a fault in the caching logic. We dump the expiry time of cache entries to disk, but when we re-import, the
node-cachelibrary does not honour the expiry timestamps; instead, it just sets a standard time to live. Since each built is short lived, this means data never actually expires from the cache.