Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache github information about the same repository #274

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

holly-cummins
Copy link
Collaborator

@holly-cummins holly-cummins commented Aug 1, 2023

We're seeing some grey icons for extensions whose URL we definitely know (so we should be able to work out an image). The issue is likely caused by the GitHub rate limiter (despite retries and backing off).

We would ideally cache information between Actions runs (#276), using the Gatsby cache facility and the GitHub actions cache facility, but a simpler solution will get us quite a lot of the way; for repos like camel and quarkus, we don't need to query the repo for each extension that lives in it.

The two exceptions are

  • issue counts for quarkus, because we use labels to narrow down the issues to the relevant ones
  • extension-specific directory listings (we look for subfolders with the artifact id in the name, to try and find the quarkus-extension.yaml so we can link to it)

Even if we query just issues and the directory listings, that's a savings, because the GitHub rate limiter measures amount of information/complexity of queries, not just the number of queries.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

🙈 The PR is closed and the preview is expired.

@holly-cummins holly-cummins requested a review from gsmet August 2, 2023 07:38
@holly-cummins holly-cummins marked this pull request as draft August 2, 2023 10:16
@holly-cummins holly-cummins removed the request for review from gsmet August 2, 2023 10:17
@holly-cummins holly-cummins force-pushed the git-caching branch 2 times, most recently from 1aab649 to 6fe22ae Compare August 2, 2023 16:11
@gsmet
Copy link
Member

gsmet commented Aug 2, 2023

I will trust you on that, feel free to merge when you're happy :). Thanks.

@holly-cummins holly-cummins marked this pull request as ready for review August 3, 2023 09:01
@holly-cummins holly-cummins merged commit ca7cf94 into quarkusio:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants