Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark cards for relocated extensions with text and different styling #1177

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Mark cards for relocated extensions with text and different styling #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/extension-card.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const Card = styled(props => <Link {...props} />)`
background: var(--card-background-color) 0 0 no-repeat padding-box;
color: var(--main-text-color);
border: ${props =>
props.$unlisted ? "1px solid var(--unlisted-outline-color)" : "1px solid var(--card-outline)"};
props.$unlisted || props.$superseded ? "1px solid var(--unlisted-outline-color)" : "1px solid var(--card-outline)"};
border-radius: 10px;
opacity: 1;
display: flex;
Expand Down Expand Up @@ -47,7 +47,7 @@ const ExtensionName = styled.div`
font-size: var(--font-size);
font-weight: var(--font-weight-awfully-bold);
letter-spacing: 0;
color: ${props => (props.$unlisted ? "var(--card-outline)" : "var(--main-text-color)")};
color: ${props => (props.$unlisted || props.superseded ? "var(--card-outline)" : "var(--main-text-color)")};
opacity: 1;
width: 100%;
padding-bottom: 2px;
Expand Down Expand Up @@ -87,8 +87,8 @@ const ExtensionDescription = styled.div`
`

const ExtensionInfo = styled.div`
color: ${props => (props.$unlisted ? "var(--danger-color)" : "var(--main-text-color)")};
text-transform: ${props => (props.$unlisted ? "uppercase" : "none")};
color: ${props => (props.$unlisted ? "var(--danger-color)" : props.$superseded ? "var(--breadcrumb-background-color)" : "var(--main-text-color)")};
text-transform: ${props => (props.$unlisted || props.$superseded ? "uppercase" : "none")};
text-align: left;
font-size: 0.7rem;
opacity: 1;
Expand All @@ -115,17 +115,18 @@ const spacer = "\u00A0"

const ExtensionCard = ({ extension }) => {
const unlisted = extension.metadata.unlisted
const superseded = extension.isSuperseded

return (
<Card to={extension.slug} $unlisted={unlisted}>
<Card to={extension.slug} $unlisted={unlisted} $superseded={superseded}>
<MainInformation>
<Logo extension={extension} />
<ExtensionName $unlisted={unlisted}>{extension.name}</ExtensionName>
<ExtensionName $unlisted={unlisted} $superseded={superseded}>{extension.name}</ExtensionName>
<ExtensionDescription>{extension.description}</ExtensionDescription>
</MainInformation>
<FinerDetails>
<ExtensionInfo $unlisted={unlisted}>
{unlisted ? "Unlisted" : spacer}
<ExtensionInfo $unlisted={unlisted} $superseded={superseded}>
{unlisted ? "Unlisted" : superseded ? "Relocated" : spacer}
</ExtensionInfo>
<ExtensionInfo>
{extension.metadata?.categories?.length > 0
Expand Down
25 changes: 25 additions & 0 deletions src/components/extension-card.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,29 @@ describe("extension card", () => {
expect(screen.getByText(/unlisted/i)).toBeTruthy()
})
})

describe("a superseded extension", () => {
const category = "jewellery"
const extension = {
name: "JRuby",
slug: "jruby-slug",
isSuperseded: true,
metadata: { categories: [category] },
}

beforeEach(() => {
render(<ExtensionCard extension={extension} />)
})

// This is a weak test, because css variables don't turn up in the computed style, so we can't make assertions about the style
// leaving this here just to check nothing breaks
it("renders the extension name", () => {
expect(screen.getByText(extension.name)).toBeTruthy()
})

it("adds a 'relocated' label", () => {
expect(screen.getByText(/relocated/i)).toBeTruthy()
})
})

})
Loading