Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use babel loose mode, to resolve warning #1084

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

holly-cummins
Copy link
Collaborator

Loose mode triggers a huge volume of warnings in the build logs; it also risks slightly broken semantics, potentially,

warning Though the "loose" option was set to "false" in your @babel/preset-env config, it will not be used for @babel/plugin-transform-class-properties since the "loose" mode option was set to "true" for @babel/plugin-transform-private-property-in-object.
The "loose" option must be the same for @babel/plugin-transform-class-properties, @babel/plugin-transform-private-methods and @babel/plugin-transform-private-property-in-object (when they are enabled): you can silence this warning by explicitly adding
	["@babel/plugin-transform-class-properties", { "loose": true }]
to the "plugins" section of your Babel config.

@holly-cummins holly-cummins merged commit 9694c6d into quarkusio:main Jul 4, 2024
3 checks passed
Copy link

github-actions bot commented Jul 4, 2024

🚀 PR Preview 071c03a has been successfully built and deployed to https://extensions-quarkus-pr-1084-preview.surge.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant