Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend Google analytics #191

Merged
merged 13 commits into from
Nov 22, 2019
Merged

Backend Google analytics #191

merged 13 commits into from
Nov 22, 2019

Conversation

edewit
Copy link
Collaborator

@edewit edewit commented Oct 28, 2019

fixing #126

@edewit edewit requested a review from ia3andy October 28, 2019 11:53
ia3andy
ia3andy approved these changes Oct 28, 2019
View reviewed changes
Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very very good job @edewit !!

@ia3andy
Copy link
Collaborator

ia3andy commented Nov 6, 2019

I am still figuring things out before it goes to production:

  1. We need to filter out calls that are not /api (or make sure it's already filtered) to avoid tracking liveness/.. stuff
  2. I am not sure yet if we should use pageview or events

@edewit
Copy link
Collaborator Author

edewit commented Nov 7, 2019

The health checks are handled before, so there is no need to filter

@ia3andy ia3andy changed the title Google analytics [WIP] Google analytics Nov 8, 2019
@ia3andy ia3andy changed the title [WIP] Google analytics [WIP] Backend Google analytics Nov 19, 2019
@ia3andy ia3andy changed the title [WIP] Backend Google analytics Backend Google analytics Nov 22, 2019
@ia3andy ia3andy merged commit f580389 into quarkusio:master Nov 22, 2019
ia3andy added a commit that referenced this pull request Nov 22, 2019
@ia3andy
Revert "Backend Google analytics (#191)"
47affee 
This reverts commit f580389
ia3andy added a commit that referenced this pull request Nov 22, 2019
@ia3andy
Google Analytics in the backend
8c1513d 
Revert "Revert "Backend Google analytics (#191)""

This reverts commit 47affee

Revert "Revert "Use ConfigManager in GA""

This reverts commit c638171

Revert "Revert "Enable https and use Provider for gaTrackingId""

This reverts commit 21c7de4

Change native image xmx
@maxandersen maxandersen mentioned this pull request Dec 5, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edewit @ia3andy