Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: send url to bitly to have cool curl command #178

Closed
wants to merge 14 commits into from

Conversation

edewit
Copy link
Collaborator

@edewit edewit commented Oct 22, 2019

fixes #154

@ia3andy
Copy link
Collaborator

ia3andy commented Oct 22, 2019

So cool, let me git it a try 👍

@ia3andy ia3andy changed the title fix: send url to bitly to have cool curl command [WIP] fix: send url to bitly to have cool curl command Oct 22, 2019
@edewit edewit force-pushed the short-curl-url branch 2 times, most recently from 80d4c52 to ace162d Compare November 7, 2019 07:44
@edewit
Copy link
Collaborator Author

edewit commented Nov 14, 2019

a PR to this PR that replaces bitly with it's own mongo database edewit#1

Copy link
Collaborator

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to disable the feature by default

@edewit
Copy link
Collaborator Author

edewit commented Nov 19, 2019

it is disabled by default

@ia3andy
Copy link
Collaborator

ia3andy commented Nov 19, 2019

Prefect then, I'll have a last pass on it later (start it and all) and I guess it will be ready to roll

@ia3andy
Copy link
Collaborator

ia3andy commented Jan 21, 2020

We decided to use #280 instead.

@ia3andy ia3andy closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download urls are too long, a tiny url feature would be great
2 participants