Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quarkus QE test framework to 1.2.0.Beta15 #889

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Oct 29, 2022

  • This update should address exceptions in cleanup for operator managed resources.

Depends on quarkus-qe/quarkus-test-framework#609

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

* This update should address exceptions in cleanup for operator managed
  resources.
@mjurc mjurc self-assigned this Oct 29, 2022
@michalvavrik
Copy link
Member

Let's wait for quarkus-qe/quarkus-test-framework#609, I'm here all week.

@mjurc
Copy link
Member Author

mjurc commented Oct 29, 2022

run tests

@michalvavrik
Copy link
Member

michalvavrik commented Oct 29, 2022

I didn't see failures of HTTP: minimum in last couple of daily builds, although none of changes in quarkus-qe/quarkus-test-framework#609 should cause it. Can you double check that failures are not related before we merge the PR, please?

@michalvavrik
Copy link
Member

OC tests didn't run as workers were offline.

@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

I think following failures

io.quarkus.ts.hibernate.reactive.openshift.OpenShiftHibernateReactiveMsSQLIT.io.quarkus.ts.hibernate.reactive.openshift.OpenShiftHibernateReactiveMsSQLIT
io.quarkus.ts.reactive.rest.data.panache.OpenShiftMssqlPanacheResourceIT.io.quarkus.ts.reactive.rest.data.panache.OpenShiftMssqlPanacheResourceIT
io.quarkus.ts.sqldb.sqlapp.OpenShiftMssqlDatabaseIT.io.quarkus.ts.sqldb.sqlapp.OpenShiftMssqlDatabaseIT

are due to admin policy for mcr.microsoft.com/mssql/rhel/server:2019-latest that we dropped lately

@michalvavrik
Copy link
Member

michalvavrik commented Oct 30, 2022

@fedinskiy failure OpenShiftApiServerConfigMapConfigIT, OpenShiftApiServerConfigSecretConfigIT, OpenShiftConfigSourcePriorityIT, OpenShiftFileSystemConfigMapConfigIT, OpenShiftFileSystemConfigSecretConfigIT are down to #886

Failed to load config value of type class java.lang.String for: secret.ipFailed to load config value of type class java.lang.String for: the.answerFailed to load config value of type class java.lang.String for: secret.password

Could you please fix them and also check (make assumption) why it didn't appear in PR CI runs? I remember we run them. Thank you

@mjurc OpenShiftLifecycleApplicationIT failure is IMHO related to https://github.com/quarkus-qe/quarkus-test-suite/blob/main/lifecycle-application/pom.xml#L43, could you address the failure, please?

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on OpenShiftLifecycleApplicationIT.

@mjurc
Copy link
Member Author

mjurc commented Oct 30, 2022

I think following failures

io.quarkus.ts.hibernate.reactive.openshift.OpenShiftHibernateReactiveMsSQLIT.io.quarkus.ts.hibernate.reactive.openshift.OpenShiftHibernateReactiveMsSQLIT io.quarkus.ts.reactive.rest.data.panache.OpenShiftMssqlPanacheResourceIT.io.quarkus.ts.reactive.rest.data.panache.OpenShiftMssqlPanacheResourceIT io.quarkus.ts.sqldb.sqlapp.OpenShiftMssqlDatabaseIT.io.quarkus.ts.sqldb.sqlapp.OpenShiftMssqlDatabaseIT

are due to admin policy for mcr.microsoft.com/mssql/rhel/server:2019-latest that we dropped lately

We should disable those tests as the workaround broken several operators. I've opened #891.

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-run from my workstation OpenShiftLifecycleApplicationIT with 1.2.0.Beta15 and it's fine. Maybe network/infra blip.

@michalvavrik michalvavrik merged commit 0e688ef into quarkus-qe:main Oct 30, 2022
@pjgg
Copy link
Contributor

pjgg commented Oct 31, 2022

Do we need to backport this PR? @mjurc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants