Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep PEM files in native mode #695

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Keep PEM files in native mode #695

merged 1 commit into from
Jun 8, 2022

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Jun 8, 2022 •
edited
Loading

Summary

PEM files private-key.pem and public-key.pem were not kept, thus f.e. OpenShiftCookieJwtSecurityIT#securedEveryoneViewGroup was failing.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Keep PEM files in native mode
06aece5 
f.e. `OpenShiftCookieJwtSecurityIT#securedEveryoneViewGroup` is failing without this fix.
@michalvavrik michalvavrik requested a review from fedinskiy June 8, 2022 10:09
@michalvavrik michalvavrik self-assigned this Jun 8, 2022
@michalvavrik michalvavrik added the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 8, 2022
pjgg
pjgg approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedinskiy fedinskiy merged commit 41c12bb into quarkus-qe:main Jun 8, 2022
@michalvavrik michalvavrik deleted the feature/keep-pem-file-in-native branch June 8, 2022 10:46
@pjgg pjgg mentioned this pull request Jun 8, 2022
Merged
1 task
@pjgg pjgg added this to the 2.7 milestone Jun 9, 2022
@pjgg pjgg removed the triage/backport-2.7? It needs to backport changes to branch 2.7 label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedinskiy fedinskiy fedinskiy approved these changes

@pjgg pjgg pjgg approved these changes

Assignees

@michalvavrik michalvavrik

Labels
None yet
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@michalvavrik @pjgg @fedinskiy