Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test of annotated Gauge metrics #653

Merged
merged 1 commit into from
May 19, 2022
Merged

Extend test of annotated Gauge metrics #653

merged 1 commit into from
May 19, 2022

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented May 18, 2022

Summary

Define multiple @Gauge metrics in a class and verify that all of them
are being recorded.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jsmrcka jsmrcka requested a review from pjgg May 18, 2022 14:18
@jsmrcka jsmrcka self-assigned this May 18, 2022
@jsmrcka
Extend test of annotated Gauge metrics
9bd4284 
Define multiple `@Gauge` metrics in a class and verify that all of them
are being recorded.
@jsmrcka jsmrcka force-pushed the feature/micrometer-gauge branch from 793bb08 to 9bd4284 Compare May 19, 2022 06:26
pjgg
pjgg approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjgg pjgg merged commit 482077d into quarkus-qe:main May 19, 2022
@jsmrcka jsmrcka deleted the feature/micrometer-gauge branch May 19, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg approved these changes

Assignees

@jsmrcka jsmrcka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsmrcka @pjgg