Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #634

Merged
merged 1 commit into from
May 5, 2022
Merged

Fix failing tests #634

merged 1 commit into from
May 5, 2022

Conversation

fedinskiy
Copy link
Contributor

Put postgres data dir to folder, where root access is not required
Remove duplicated consul image

Summary

(Summarize the problem solved by this PR, and how to verify it manually)

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Put postgres data dir to folder, where root access is not required
Remove duplicated consul image
@fedinskiy fedinskiy requested a review from jsmrcka May 5, 2022 07:43
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is a follow-up to #624, right?

What is the reason for defining the PGDATA property? Does it only involve OpenShift scenarios, or baremetal as well?

I noticed it's only defined for containers using postgresql.13.image, does it involve both docker.io/library/postgres:13.6 and registry.redhat.io/rhscl/postgresql-13-rhel7? And postgresql.10.image does not need it?

What about other scenarios, that use PostgreSQL, e.g. PostgresqlMultitenantHibernateIT, or PostgresqlHandlerIT?

@fedinskiy
Copy link
Contributor Author

@jsmrcka
Yes, this is basically the same as #624 , but for tests which were missed

Pgdata property points to folder, where postgres stores data. Default location in /var requires advanced rights, which cannot be provided in Openshift, but it works fine in baremetal. Up to this moment, these problems only affected Openshift and library images, so I didn't apply this fix for other combinations.

@jsmrcka jsmrcka self-requested a review May 5, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants