Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute module update #557

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Qute module update #557

merged 2 commits into from
Mar 14, 2022

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Mar 3, 2022

Qute module update

2 different message interfaces, using MessageBundles.get and injection, localized template render

Fixes #521

2 different message interfaces, using MessageBundles.get and injection, localized template render
@rsvoboda
Copy link
Member Author

rsvoboda commented Mar 3, 2022

Concern: There was an issue filed in upstream that the original scenario reproduces.

Response: End user use case was invalid according to the details and use-cases described in https://quarkus.io/guides/qute-reference#localization
I believe that the reproducer attached in the GH issue is a corner case and not following the stuff described in qute guide (e.g. use of AppMessagesProviderm, empty messages in AlertMessages). Our tests should be using the intended approaches. GH issue was closed and the owner didn't come back. If you believe the issue is still valid you can communicate that on the GH issue, but we should have sane test coverage.

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these commits be joined?

@rsvoboda
Copy link
Member Author

Second commit is related to #226 that's why it was done as separate one.

@fedinskiy fedinskiy merged commit 21d7a39 into quarkus-qe:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable qute/multimodule
2 participants