Adapt main to Quarkus 999-SNAPSHOT #238
Conversation
| @@ -27,6 +24,6 @@ public void shouldDataSourceBeProperlyConfigured() { | |||
| } | |||
|
|
|||
| private static final RequestSpecification dataSourcePath() { | |||
| return given().accept(MediaType.APPLICATION_JSON).contentType(ContentType.JSON).when().basePath(DATA_SOURCE_PATH); | |||
| return given().when().basePath(DATA_SOURCE_PATH); | |||
There was a problem hiding this comment.
This was wrong and using reactive fails which I think it's expected. It's now corrected.
|
|
| @@ -63,6 +65,8 @@ public void testRequestScope() { | |||
| //This is for regression test for https://github.com/quarkusio/quarkus/pull/12234 | |||
| @Test | |||
| @DisplayName("session scope") | |||
| @DisabledOnQuarkusVersion(version = "2.3.*", reason = "quarkus-spring-data-rest is now reactive") | |||
There was a problem hiding this comment.
Is it temporary fix? Because it looks like quarkusio/quarkus#12233 is about spring DI and should be orthogonal to spring-data
There was a problem hiding this comment.
As it now uses reactive approach, I would say it's a permanent fix. Wdyt @jsmrcka ?
There was a problem hiding this comment.
TBH, I don't understand why this doesn't work with reactive approach.
And also, why is it disabled just for 2.3.*? I suppose it's not going to work for any future version.
There was a problem hiding this comment.
This is a good point... as I dropped the undertow dependency, this is not going to work ever, so we should delete this test case.
It does not work because the reactive approach does not propagate the session id.
Updated |
This change is caused by quarkusio/quarkus#19875 which as far I understood, it's not going to be reverted or fixed. Guides updates in quarkusio/quarkus#19995
This change is caused by quarkusio/quarkus#19875 which as far I understood, it's not going to be reverted or fixed.
Guides updates in quarkusio/quarkus#19995