Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily build by taking Quarkus QE Test Framework dependencies from Sonatype snapshot repository and stop building Quarkus main #2243

Merged

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 9, 2024

Summary

  • Daily build is failing as following changes in Quarkus QE Test Framewok, we now use 999-SNAPSHOT deployed to Sonatype snapshot repository, however daily build is not configured to use the snapshot repository. This PR sets daily build to use it, and as we already use the snapshot repository where Quarkus main build is, there is little point to keep building it (we can save some time, green planet :-) ).
  • WebAuthn module fails to compile due to changes in the Reimplement security-webauthn on top of webauthn4j quarkusio/quarkus#44105, I'll have look later this week if I can patch it somehow
  • I didn't check Jenkins jobs whether someone is using "non-snaphost" Maven settings, I'll check later if we can drop it as well

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik force-pushed the feature/fix-daily-build-and-compilation branch 3 times, most recently from e01d4ba to 378e9ce Compare December 9, 2024 21:37
@michalvavrik michalvavrik force-pushed the feature/fix-daily-build-and-compilation branch from 378e9ce to ad40c8b Compare December 9, 2024 21:56
@michalvavrik michalvavrik requested a review from gtroitsk December 9, 2024 23:53
Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if it works :)

@gtroitsk gtroitsk merged commit 801e3e6 into quarkus-qe:main Dec 10, 2024
14 checks passed
@michalvavrik michalvavrik deleted the feature/fix-daily-build-and-compilation branch December 10, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants