Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Mutual TLS with Management interface configured using TLS Registry extension and certificate reloading #1986

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Test Mutual TLS with Management interface configured using TLS Registry extension and certificate reloading #1986

merged 1 commit into from
Sep 6, 2024

Conversation

michalvavrik
Copy link
Member

Summary

  • tests TLS registry with management interface
  • tests certificate reloading

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from jedla97 September 6, 2024 10:15
@michalvavrik michalvavrik force-pushed the feature/tls-registry-cert-reloading branch from 944f8e4 to f61cc26 Compare September 6, 2024 10:28
@michalvavrik
Copy link
Member Author

just tweaked one comment, TD is finished and ready for review

jedla97
jedla97 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't spot any problem. Also +1 on the inline comments as it is nice guidance what's happening

@jedla97 jedla97 merged commit 3595a00 into quarkus-qe:main Sep 6, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/tls-registry-cert-reloading branch September 6, 2024 11:34
@michalvavrik michalvavrik mentioned this pull request Oct 2, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedla97 jedla97 jedla97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @jedla97